-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contrast and Brightness as Visual-attribute #135
Comments
Upon further investigation, it seems that Luminance: Luminance is the luminous intensity projected on a given area and direction. Luminance typically describes the intensity of emitted light. Brightness: We perceive brightness when lumens fall on the rods and cones of our retina. When we speak of brightness, we use subjective words like “dim” or “brilliant” because brightness cannot be measured like luminance but can be scaled in percentages. Here, I am not sure if we want to differentiate the difference between the two. My current take is to keep the luminance and not to include |
Here is the definition of Contrast is the difference between the luminance of two objects. Either of the following equations can formalize the definition of contrast:
Source:
|
After HWG discussion --- it was agreed we should put in Also, formula 1 is a relative difference ... should that be in the description? The definition also indicates two objects. Should this be a Relation such as "Contrast-between". Do the two references both give both of these definitions? |
Contrast should be a Visual-attribute (not a Relation). Some examples:
|
Thanks a lot, @VisLab and @dorahermes, for your support.
I agree with @dorahermes that it should be under
Both formulas talk about differences in luminance. Contrast needs two objects to be defined. However, I think that Contrast-between would cause unnecessary repetition. For example, for a foreground gray circle and a white background, the short HED tag will look like: (Visual-presentation, ((Foreground-view, (Circle, Gray)), (Background-view, White), Contrast/0.5))
|
Talking to @smakeig, he emphasized that there are many contrasts, and what we are referring to here is luminance contrast. The first source also emphasizes this point by comparing the attributes of color contrast and luminance contrast. So, I wonder if it would be better to have |
I agree that |
I wonder, though, whether luminance-contrast, as we are seeking to use in
the Present movie annotation project, is not better thought of as a measure
applied to events rather than a response attribute per se... Here, we are
using it as defined by a particular formula (not specified in the
HED schema, of course, as it has near-arbitrary parameters). Further,
these parameters and the formula they belong to are not accepted
standards. Compare, for example, the use of dB to specify the volume of a
sound - here, several dB scales are recognized (Db A, etc.). Of course,
the same '?' might be raised about many other event attributes. For
example, "color, 'very-dark-red'" does have an agreed formal definition, as
does 'latency, 21.344 sec'. It is doubtless of use to enter e.g. computed
luminance contrast values in an events.tsv file column -- and HED tools
should be able to incorporate this into the HED string for (here) each HED
"movie-shot, Onset" event marker - to allow HED search to pick out events
with e.g." luminance-contrast > 3".
Perhaps HED should have a list of recommended measure column name labels
that are not 'at the level of' standard HED schema terms...
Else - perhaps we should introduce a MovingImage library schema that
defines not only 'luminance-contrast' but also parameters entering into its
definition:
e.g.
"luminance-ratio, 2.1777;
defined by npreceding-frames, 3; nfollowing-frames, 3;
luminance--measure, RMS; luminance-smoothing, mean"
The above would seem like 'overkill' ... as meaningful variations in this
definition are not likely to be represented in a data archive, certainly
not on the scale that would make their differences across datasets
meaningfully testable...
?
…On Fri, Feb 9, 2024 at 10:26 AM dorahermes ***@***.***> wrote:
I agree that Luminance-contrast is clear and contrast-between does not
work. Note that contrast can also be calculated using sets of filters in
visual encoding models.
—
Reply to this email directly, view it on GitHub
<https://urldefense.com/v3/__https://github.com/hed-standard/hed-schemas/issues/135*issuecomment-1936409084__;Iw!!Mih3wA!Ec1YQQ5cf5XXF2uzsYFG2CisA2ZlMluN_ooE2Dq1gjzSnsvsrRsG7wqz_lBcVVxzoWEMm3p6l5ULLwTfvyISxOyq$>,
or unsubscribe
<https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AKN2SFQ3OYRRSFPMB4YPAELYSZS6TAVCNFSM6AAAAABCJN6A46VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZWGQYDSMBYGQ__;!!Mih3wA!Ec1YQQ5cf5XXF2uzsYFG2CisA2ZlMluN_ooE2Dq1gjzSnsvsrRsG7wqz_lBcVVxzoWEMm3p6l5ULLwTfvxXzSzO3$>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
I meant that comment to begin, "I wonder, though, whether
luminance-contrast, as we are seeking to use in the Present movie
annotation project, is not better thought of as a measure applied to events
rather than AN EVENT attribute per se..."
…On Sun, Feb 11, 2024 at 1:34 PM Scott Makeig ***@***.***> wrote:
I wonder, though, whether luminance-contrast, as we are seeking to use in
the Present movie annotation project, is not better thought of as a measure
applied to events rather than a response attribute per se... Here, we are
using it as defined by a particular formula (not specified in the
HED schema, of course, as it has near-arbitrary parameters). Further,
these parameters and the formula they belong to are not accepted
standards. Compare, for example, the use of dB to specify the volume of a
sound - here, several dB scales are recognized (Db A, etc.). Of course,
the same '?' might be raised about many other event attributes. For
example, "color, 'very-dark-red'" does have an agreed formal definition, as
does 'latency, 21.344 sec'. It is doubtless of use to enter e.g. computed
luminance contrast values in an events.tsv file column -- and HED tools
should be able to incorporate this into the HED string for (here) each HED
"movie-shot, Onset" event marker - to allow HED search to pick out events
with e.g." luminance-contrast > 3".
Perhaps HED should have a list of recommended measure column name labels
that are not 'at the level of' standard HED schema terms...
Else - perhaps we should introduce a MovingImage library schema that
defines not only 'luminance-contrast' but also parameters entering into its
definition:
e.g.
"luminance-ratio, 2.1777;
defined by npreceding-frames, 3; nfollowing-frames, 3;
luminance--measure, RMS; luminance-smoothing, mean"
The above would seem like 'overkill' ... as meaningful variations in this
definition are not likely to be represented in a data archive, certainly
not on the scale that would make their differences across datasets
meaningfully testable...
?
On Fri, Feb 9, 2024 at 10:26 AM dorahermes ***@***.***>
wrote:
> I agree that Luminance-contrast is clear and contrast-between does not
> work. Note that contrast can also be calculated using sets of filters in
> visual encoding models.
>
> —
> Reply to this email directly, view it on GitHub
> <https://urldefense.com/v3/__https://github.com/hed-standard/hed-schemas/issues/135*issuecomment-1936409084__;Iw!!Mih3wA!Ec1YQQ5cf5XXF2uzsYFG2CisA2ZlMluN_ooE2Dq1gjzSnsvsrRsG7wqz_lBcVVxzoWEMm3p6l5ULLwTfvyISxOyq$>,
> or unsubscribe
> <https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AKN2SFQ3OYRRSFPMB4YPAELYSZS6TAVCNFSM6AAAAABCJN6A46VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZWGQYDSMBYGQ__;!!Mih3wA!Ec1YQQ5cf5XXF2uzsYFG2CisA2ZlMluN_ooE2Dq1gjzSnsvsrRsG7wqz_lBcVVxzoWEMm3p6l5ULLwTfvxXzSzO3$>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
|
@smakeig, we are not using), at least currently, The Luminance Ratio for the Present Movie (as briefly described under BIDS issue 153 does not seem to be able to benefit from This is not to discount the importance of annotating temporal context; I just don't think that |
To summarize, here is what we have discussed so far Suggestion to include Luminance-contrast in the base schema: Tag: Parent: Definition: Luminance contrast is the difference between the luminance of two objects. The suggested quantification method is the relative difference measure of luminance: Contrast-luminance = (Lmax - Lmin) / (Lmax + Lmin), where Lmax and Lmin are the maximum and minimum luminance of [specific portions of] an image. Source: Legge, G. E., D. H. Parish, A. Luebker, and L. H. Wurm. 1990. “Psychophysics of Reading. XI. Comparing Color Contrast and Luminance Contrast.” Journal of the Optical Society of America. A, Optics and Image Science 7 (10): 2002–10. Accept-value: Yes, Type = (Non-negative, Fraction), Range = 0 to 1. Example: Represent a gray circle over a white background with a contrast of 0.5.
|
This definition is incorrect in many cases and only applies to a subset of luminance contrast measurements (you are suggesting Michelson) and it can be calculated in multiple ways as mentioned above. I would therefore not give a 'suggested method for quantification', as there are many methods (Michelson, Weber, RMS, and other filtering approaches). Also note that the RMS contrast is not a fraction. I think the definition should be more general and allow future sub-tree extension with such specifics, e.g: Definition: Luminance contrast is the difference in luminance in [specific portions of] a scene or image. Accept-value: Yes, Type = (Non-negative), Range = 0 to 1. |
Thanks, @dorahermes,
I don't think either of the definitions is incorrect. However, definition 1 is more general since it does not constrain There are indeed several ways for quantification of contrast (see Wikipedia page on contrast). We should encourage the inclusion of the quantification method in the definition somehow. Also, in my opinion, providing a recommended method to quantify With a quick literature search, I observed that the Michelson definition seemed to be used often, so I added that as the suggested quantification method. I agree that the type should not be |
I have calculated contrast before in encoding models using sets of Gabor filters, and while it would be useful to have some suggestions, I do not think we should recommend any one in particular. Specific recommendations/luminance contrast types should be reserved for a level deeper. |
Type of value would be done with |
Addressed in PR#149 |
While annotating the Healthy Brain Network project's Surround Suppression task, I found that
Opacity
andLunminence
,Hue
andSaturation
, but I can't findContrast
andBrightness
. While these values are potentially dependent, having the full range of definitions helps describe the events.The text was updated successfully, but these errors were encountered: