Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create an account feedback #1

Open
2 tasks
SimiHunjan opened this issue Jul 10, 2024 · 3 comments
Open
2 tasks

Create an account feedback #1

SimiHunjan opened this issue Jul 10, 2024 · 3 comments

Comments

@SimiHunjan
Copy link
Contributor

SimiHunjan commented Jul 10, 2024

Feedback items for create an account tutorial.

  • Q: Are we standardizing on using the ECDSA key for all tutorials?

Previous used ED25519 because that was the only key type that was supported. If so, we would need to update the portal guide to point to grabbing those keys for those users as well. We also need to consider updating other areas in tutorials/examples where use ED25519 keys and replace with ECDSA. The docs should provide consistency throughout unless maybe we are demonstrating a use case for a specific key type and its benefits.

const operatorKey = PrivateKey.fromStringECDSA(operatorKeyStr);

we should also call out the key type here so it is clear because portal displays both types of keys to be clear which one is being used:

const operatorKeyStr = process.env.OPERATOR_ACCOUNT_PRIVATE_KEY;

to something like

const operatorECSDAKeyStr = process.env.OPERATOR_ACCOUNT_ECDSA_PRIVATE_KEY;
  • Feedback: If we specifically need the hex encoded key in this statement then we should replace the following

Enter your operator account (ECDSA) private key

with

Enter your operator account (ECDSA) hex encoded private key

Feedback: I don't know what I have to answer this prompt

> 0x1a83c7c0fe90a1d24b8f5bcd3b074aecad834d7a9fbe130ea133eb4e01775300
Fetching:  https://testnet.mirrornode.hedera.com/api/v1/accounts?account.publickey=0x03a9228366eb335c791c1d2cb1da6b237688716198e543cd13fbb2803c4ca6b63a&balance=true&limit=1&order=desc
Enter a BIP-39 seed phrase
(enter blank value generate a new one at random)
> 
```

I provided by key and we tied the account to that key I am assuming from querying the public key of the private key. Not sure what I have to this for.


**Q: Is this the number of accounts or private keys being created off of the recovery phrase?**

```
Randomly-generated seed phrase:  rather water fish fury short rate evoke now glare fish harsh top
Enter a number of accounts to generate from your BIP-39 seed phrase
Default: "1"
(enter blank value to use default value)
> 
```
@SimiHunjan
Copy link
Contributor Author

Q: Is this the number of accounts or private keys being created off of the recovery phrase?

Randomly-generated seed phrase:  rather water fish fury short rate evoke now glare fish harsh top
Enter a number of accounts to generate from your BIP-39 seed phrase
Default: "1"
(enter blank value to use default value)
> 

@SimiHunjan
Copy link
Contributor Author

Q: Can this question be removed from my set-up for create account?

Enter your preferred JSON-RPC endpoint URL
Current: "https://7546-hederadev-hellofuturewo-ho8ld4p1rdw.ws-us115.gitpod.io"
(enter blank to re-use the above value)

The relay set-up is not needed for this example. Looking to keep the example focused on what is needed for the task.

@SimiHunjan
Copy link
Contributor Author

Feedback: I am confused why I need three accounts when we have the operator account as one account and the tutorial is going to show how to create a new account.

There are three accounts listed in the .env file (not yet created just a private key derived). Not sure why we need these as the transfer example can show the operator account transferring to the new account that was created as the example.

bguiz pushed a commit that referenced this issue Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant