Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(redocly): check bundle and run lint #38

Merged
merged 2 commits into from
Jun 4, 2024
Merged

feat(redocly): check bundle and run lint #38

merged 2 commits into from
Jun 4, 2024

Conversation

MathieuVeber
Copy link
Contributor

No description provided.

@MathieuVeber MathieuVeber requested a review from a team June 3, 2024 14:03
@MathieuVeber MathieuVeber self-assigned this Jun 3, 2024
@MathieuVeber MathieuVeber enabled auto-merge (squash) June 3, 2024 14:04
Styrke
Styrke requested changes Jun 3, 2024
View reviewed changes
@MathieuVeber MathieuVeber requested a review from Styrke June 3, 2024 14:26
aimeerivers
aimeerivers requested changes Jun 3, 2024
View reviewed changes
Copy link
Member

@aimeerivers aimeerivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a small suggestion.

@aimeerivers
Copy link
Member

do we have an example of a PR that runs these checks (and fails?) .. would be good to see how it looks.

@MathieuVeber
Copy link
Contributor Author

do we have an example of a PR that runs these checks (and fails?) .. would be good to see how it looks.

Yes in data-service

Check out the failing actions 😉 https://github.com/hedia-team/data-service/actions/workflows/continuous-integration.yml

@MathieuVeber
Copy link
Contributor Author

It did help me to fix data-service so it's already useful 😜

aimeerivers
aimeerivers approved these changes Jun 3, 2024
View reviewed changes
Copy link
Member

@aimeerivers aimeerivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excellent! i really like your step naming too! was going to say something about imperative verbs, but i see you already fixed it! 😄

@aimeerivers aimeerivers self-requested a review June 4, 2024 06:12
aimeerivers
aimeerivers approved these changes Jun 4, 2024
View reviewed changes
Copy link
Member

@aimeerivers aimeerivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just coming back to confirm, i don't require any changes.

@MathieuVeber
Copy link
Contributor Author

just coming back to confirm, i don't require any changes.

This is not about you it's about @Styrke 😜

Styrke
Styrke approved these changes Jun 4, 2024
View reviewed changes
Copy link
Contributor

@Styrke Styrke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Looking forward to it. 👍

Sorry, I didn't realize the PR was waiting for me.

@MathieuVeber MathieuVeber merged commit e7d8c79 into main Jun 4, 2024
1 check passed
@MathieuVeber MathieuVeber deleted the redocly branch June 4, 2024 08:45
@MathieuVeber MathieuVeber linked an issue Jun 13, 2024 that may be closed by this pull request
CI automation to deploy from a release #35
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aimeerivers aimeerivers aimeerivers approved these changes

@Styrke Styrke Styrke approved these changes

Assignees

@MathieuVeber MathieuVeber

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI automation to deploy from a release
3 participants
@MathieuVeber @aimeerivers @Styrke