Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: deploy-please #40

Merged
merged 11 commits into from
Jun 12, 2024
Merged

feat: deploy-please #40

merged 11 commits into from
Jun 12, 2024

Conversation

MathieuVeber
Copy link
Contributor

@MathieuVeber MathieuVeber commented Jun 11, 2024 •
edited
Loading

Screenshot 2024-06-11 at 16 45 59

@hedia-bot hedia-bot added feature New feature for the user minor Minor release labels Jun 11, 2024
@MathieuVeber MathieuVeber marked this pull request as ready for review June 11, 2024 14:45
@MathieuVeber MathieuVeber requested a review from aimeerivers June 11, 2024 14:47
aimeerivers
aimeerivers reviewed Jun 11, 2024
View reviewed changes
Copy link
Member

@aimeerivers aimeerivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fantastic!

just curious: have you thought about how we will manage deploying to different envrionments?

like for developer-service, how will i know if i'm about to deploy to .dev or to .com ?

@MathieuVeber
Copy link
Contributor Author

fantastic!

just curious: have you thought about how we will manage deploying to different envrionments?

like for developer-service, how will i know if i'm about to deploy to .dev or to .com ?

I was thinking that .dev and .com should always be the same and if we were to have a staging environment it would probably auto-deploy. I'm open to suggestions though 😉

@aimeerivers
Copy link
Member

nice, i like it!

@MathieuVeber MathieuVeber enabled auto-merge (squash) June 12, 2024 07:36
aimeerivers
aimeerivers approved these changes Jun 12, 2024
View reviewed changes
Copy link
Member

@aimeerivers aimeerivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MathieuVeber MathieuVeber merged commit c423ddc into main Jun 12, 2024
@MathieuVeber MathieuVeber deleted the deploy-please branch June 12, 2024 13:07
@MathieuVeber MathieuVeber linked an issue Jun 13, 2024 that may be closed by this pull request
CI automation to deploy from a release #35
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aimeerivers aimeerivers aimeerivers approved these changes

Assignees

@MathieuVeber MathieuVeber

Labels
feature New feature for the user minor Minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI automation to deploy from a release
3 participants
@MathieuVeber @aimeerivers @hedia-bot