Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transparent space in png's #4

Open
xsorifc28 opened this issue Mar 8, 2016 · 5 comments
Open

Transparent space in png's #4

xsorifc28 opened this issue Mar 8, 2016 · 5 comments

Comments

@xsorifc28
Copy link

Is there a reason as to why there is a transparent gap in the png's ?

Just wondering.

@EKami
Copy link
Contributor

EKami commented Apr 18, 2016

There is none but didn't see this as a problem at the time the lib was made. Do you need pngs with no gaps?

@xsorifc28
Copy link
Author

It helps to predict the size better and adjust padding/margins. It is hard to take into account the transparency when using the icons outside of the country picker (I access the flag bitmaps elsewhere in my project).

@EKami
Copy link
Contributor

EKami commented Apr 27, 2016

Alright, having no gap in the pngs could indeed be helpful. I don't have the time for the moment to make the changes. Could you open up a PR with the removed gaps from the icons? I would be greatly appreciated.

@xsorifc28
Copy link
Author

Do you have the icons as vectors or a script already? How did you generate the original ones?

@EKami
Copy link
Contributor

EKami commented Apr 29, 2016

The flags come from this repository

xsorifc28 pushed a commit to xsorifc28/CountryPicker that referenced this issue Aug 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@EKami @xsorifc28 and others