Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nice work - exactly what I was looking for but... #22

Open
rmsj opened this issue May 26, 2022 · 4 comments
Open

Nice work - exactly what I was looking for but... #22

rmsj opened this issue May 26, 2022 · 4 comments

Comments

@rmsj
Copy link

rmsj commented May 26, 2022

Have you considered this as a PR for SQLx?

@skateinmars
Copy link
Member

Hey @rmsj
(and sorry for the delay in the answer)

Originally we created a separate package because this feature is almost only useful when using savepoints (so, with PostgreSQL only)
But maybe there is indeed a potential interest in backporting some or all of the changes to sqlx!
Please feel free to open a feature request issue on their repo

@carpii
Copy link

carpii commented Jun 29, 2023

Do we know if this was ever suggested as a merge to sqlx?

savepoints are not postgres specific, but have been part of the SQL standard for many years now (so should be widely supported).

@skateinmars
Copy link
Member

Hey @carpii thanks for your feedback
We did plan to try to get this merged to sqlx but unfortunately the upstream repository seems to be unmaintained (no commits/merge since April 2022)

Also please note, we are in the process of marking this repo as maintenance only and will stop adding any features.

@carpii
Copy link

carpii commented Jun 30, 2023

Ok, I understand. Thanks for the reply 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants