Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Add fit, predict parallel flow for multiple time-series data #30

Open
MichalChromcak opened this issue Jul 17, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@MichalChromcak
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
Once the best models are selected via functional part (run_model_selection, resp. select_model_general) or object-oriented part (ModelSelector.select_model) one usually needs to re-fit the selected models (e.g. daily) and predict with them. This part is currently missing, while this core part might be called directly from hcrystalball.

Describe the solution you'd like

  • Run CV with the persistence of ModelSelectorResults or minimal setup (only best_model might suffice here)

  • Load persisted models

  • Get the new training data

  • Run the fit_predict flow, that takes data for a subset of the partitions for which one has the models

    • Split new data training data
    • Run fit mapped over the partitions
    • Run predict mapped over the partitions
    • Reduce predictions to 1 dataframe
    • Return predictions

Describe alternatives you've considered
Adopt loading of persisted models within the flow, but as this might be stored on disk, but also in some db, let's leave that out-of-scope.

Additional context
We should ensure consistency between CV and fit-predict (frequency should be the same, horizon might change I guess, ...)

@MichalChromcak MichalChromcak added the enhancement New feature or request label Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant