-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add constexpr where appropriate #1
Comments
can you please assign me this sir. I am interested in solving this. |
Sure, assigned. |
@aniketmdinde When you do, please commit files separately and send pull requests for each. For example: Also, notice that we start commit messages with capital letters. We want to later use the commit messages for training & AI to automate it, so we want a uniform format. As always, it's okay to forget sometimes - we all do. |
I will keep this in mind |
I messed up with my contributions as I added constexpr to 3 files but accidently executed a merge request due to which I am not able to push more files. Can you please reject commits and merge so that I will start anew and make sure I perform all the commits and then merge. |
@aniketmdinde Don't worry at all, there's absolutely no problem. You most likely have local code conflicts because of the changes made in parallel. These kinds of code / merge conflicts are unavoidable for repos under active development. Your changes are completely isolated (through your fork) and do not affect the main repo. There's nothing for me to reject. You simply have to resolve all the conflicts on your end and push your changes again as a pull request, like you did the previous times. |
@aniketmdinde Also when you do, please always write "Add" (in general, like "do this": Remove..., Add..., Delete..., Update..., and so on), not in past tense: This way all issues, commit messages and Git's own messaging (like the "Merge..." in the picture above) conform to a common standard. |
Of course, use common sense, as always, and, obviously, it has to compile.
The text was updated successfully, but these errors were encountered: