Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add constexpr where appropriate #1

Open
heinsaar opened this issue Aug 18, 2023 · 7 comments
Open

Add constexpr where appropriate #1

heinsaar opened this issue Aug 18, 2023 · 7 comments
Assignees
Labels
easy Good for onboarding, few dependencies
Milestone

Comments

@heinsaar
Copy link
Owner

heinsaar commented Aug 18, 2023

Of course, use common sense, as always, and, obviously, it has to compile.

@heinsaar heinsaar added the easy Good for onboarding, few dependencies label Aug 18, 2023
@heinsaar heinsaar changed the title Add constexpr everywhere Add constexpr where appropriate Sep 17, 2023
@aniketmdinde
Copy link
Contributor

can you please assign me this sir. I am interested in solving this.

@heinsaar
Copy link
Owner Author

Sure, assigned.

@heinsaar
Copy link
Owner Author

@aniketmdinde When you do, please commit files separately and send pull requests for each. For example:
Add constexpr in utils.h
Add constexpr in version.h
And so on. This makes it easy to manage things and keep them in sync.

Also, notice that we start commit messages with capital letters. We want to later use the commit messages for training & AI to automate it, so we want a uniform format. As always, it's okay to forget sometimes - we all do.

@aniketmdinde
Copy link
Contributor

I will keep this in mind

@heinsaar heinsaar added this to the Kaizen 1.0 milestone Sep 29, 2023
@aniketmdinde
Copy link
Contributor

I messed up with my contributions as I added constexpr to 3 files but accidently executed a merge request due to which I am not able to push more files. Can you please reject commits and merge so that I will start anew and make sure I perform all the commits and then merge.
I am extremely sorry for this inconvenience.

@heinsaar
Copy link
Owner Author

heinsaar commented Oct 3, 2023

@aniketmdinde Don't worry at all, there's absolutely no problem. You most likely have local code conflicts because of the changes made in parallel. These kinds of code / merge conflicts are unavoidable for repos under active development. Your changes are completely isolated (through your fork) and do not affect the main repo. There's nothing for me to reject. You simply have to resolve all the conflicts on your end and push your changes again as a pull request, like you did the previous times.

@heinsaar
Copy link
Owner Author

heinsaar commented Oct 3, 2023

@aniketmdinde Also when you do, please always write "Add" (in general, like "do this": Remove..., Add..., Delete..., Update..., and so on), not in past tense:
image

This way all issues, commit messages and Git's own messaging (like the "Merge..." in the picture above) conform to a common standard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy Good for onboarding, few dependencies
Projects
None yet
Development

No branches or pull requests

2 participants