Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove transaction audio and animation #740

Open
arduino43 opened this issue May 25, 2024 · 3 comments
Open

Remove transaction audio and animation #740

arduino43 opened this issue May 25, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@arduino43
Copy link

When a transaction is submitted, at least on iPhone, the audio handed over to the wallet app and stops any other active streams; this seems unnecessary.

The animation also is unnecessary long and creates delays when sending many transaction; I think the default should be to submit and return.

@jthiller jthiller added the bug Something isn't working label May 25, 2024
@ChewingGlass
Copy link
Contributor

I don't think we're going to remove the animation but we can remove the audio hijacking. And potentially cut the animation short if it finishes early.

@arduino43
Copy link
Author

arduino43 commented Jun 17, 2024

I don't think we're going to remove the animation but we can remove the audio hijacking. And potentially cut the animation short if it finishes early.

Thank you. Cutting the animation would be helpful as it isn't really tied to any process, it plays regardless of transaction state; If you submit a transaction and immediately click out of the animation most times the transaction Is already completed while the animation would continue running for another 5 seconds. It's just an added delay for every transaction in most cases.

@arduino43
Copy link
Author

I don't think we're going to remove the animation but we can remove the audio hijacking. And potentially cut the animation short if it finishes early.

Any update on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants