You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I looked into this, the current dependency used grep_searcher doesn't seem to provide any information on the start / end of a specific match. So I suppose it's not an "exact search" which potentially has performance improvements over exact search. Still, if the performance impact to use a more precise grep crate to jump to a character range instead of highlighting the entire line are negligible then I think this is worth considering.
I am talking about the global_search function in helix-term/src/commands.rs
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
I looked into this, the current dependency used
grep_searcher
doesn't seem to provide any information on the start / end of a specific match. So I suppose it's not an "exact search" which potentially has performance improvements over exact search. Still, if the performance impact to use a more precise grep crate to jump to a character range instead of highlighting the entire line are negligible then I think this is worth considering.I am talking about the
global_search
function inhelix-term/src/commands.rs
Beta Was this translation helpful? Give feedback.
All reactions