Inline diagnostics are invisible when very long and should be partly shown

[louis-thevenet]

Summary

When inline diagnostics are longer than the number of lines showed by Helix, and I edit a line below the error line. Inline diagnostics disappear instead of being partly showed, leaving a long blank space.

Reproduction Steps

You can reproduce it on line 39 of the config.rs file in this branch : https://github.com/louis-thevenet/vault-tasks/tree/helix-broken-inline-diagnostics

Helix log

~/.cache/helix/helix.log

please provide a copy of `~/.cache/helix/helix.log` here if possible, you may need to redact some of the lines

Platform

Linux

Terminal Emulator

Kitty

Installation Method

flake

Helix Version

Helix 24.7 (dc941d6)

[nik-rev]

Use zz, zt or zb to be able to see them fully

[louis-thevenet]

From what I understand, when the cursor is past the line generating the large diagnostics, the virtual lines of the diagnostics are rendered and this pushes the error line up.

If the error line is pushed too high (outside of the viewport), the insert_virtual_lines still returns space for the diagnostics, but the render_virtual_lines function doesn't render those and that's why we get the blank space

[justinlovinger]

Use zz, zt or zb to be able to see them fully

That is a video in the opening post, not an image. The first frame does not show the issue. Here it is in images:

Note, the second line also has a long error, which is not displayed at all. The editor also lags significantly past that last error.