Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decouple the auto-save and auto-format options #12809

Open
Arcohol opened this issue Feb 7, 2025 · 4 comments · May be fixed by #12817
Open

Decouple the auto-save and auto-format options #12809

Arcohol opened this issue Feb 7, 2025 · 4 comments · May be fixed by #12817
Labels
C-enhancement Category: Improvements

Comments

@Arcohol
Copy link

Arcohol commented Feb 7, 2025

I’d like to suggest that auto-format be triggered only by manual saving, rather than being tied to auto-save.

Reasons:

  1. Code formatting doesn’t need to happen frequently.
  2. When both auto-save and auto-format are enabled, formatting occurs while writing code, which can be disruptive.

Decoupling these options would improve the user experience and potentially resolve issues like #11237 and #11966.
@Arcohol Arcohol added the C-enhancement Category: Improvements label Feb 7, 2025
@voiceroy
Copy link
Contributor

voiceroy commented Feb 8, 2025

Would it be better if there was an option to configure this functionality or the behavior being hardcoded into helix?

@Arcohol
Copy link
Author

Arcohol commented Feb 8, 2025

I think an option like format-on-auto-save that defaults to false would be great.

@Arcohol
Copy link
Author

Arcohol commented Feb 8, 2025

However, I still don't think it's necessary to format every time an auto-save triggers.

@voiceroy
Copy link
Contributor

voiceroy commented Feb 8, 2025

However, I still don't think it's necessary to format every time an auto-save triggers.

We'll let the user choose the behavior through config file anyway

@Arcohol Arcohol changed the title Make auto-save ignore the auto-format option Decouple the auto-save and auto-format options Feb 8, 2025
@voiceroy voiceroy linked a pull request Feb 8, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-enhancement Category: Improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Provide an option to configure formatting on auto save voiceroy/helix
2 participants
@voiceroy @Arcohol