Skip to content

Commit 198af73

Browse files
hellojavaerhellojavaer
committed
1. LRUSQLParserCache provide max sql length limit
2. Fix JSQLParserAdapter bug: SQLParsedResult.checkIfCrossPreparedStatement not work
1 parent 6e657fb commit 198af73

File tree

3 files changed

+165
-43
lines changed

3 files changed

+165
-43
lines changed

‎ddal-ddr/src/main/java/org/hellojavaer/ddal/ddr/sqlparse/cache/LRUSQLParserCache.java‎

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,14 +29,20 @@ public class LRUSQLParserCache implements SQLParserCache {
2929

3030
private volatile ConcurrentLinkedHashMap<InnerQueryKey, SQLParsedState> cache;
3131
private Integer capacity;
32+
private Integer maxSQLLength;
3233
private SQLParser sqlParser;
3334

3435
private LRUSQLParserCache() {
3536
}
3637

3738
public LRUSQLParserCache(SQLParser sqlParser, Integer capacity) {
39+
this(sqlParser, capacity, null);
40+
}
41+
42+
public LRUSQLParserCache(SQLParser sqlParser, Integer capacity, Integer maxSQLLength) {
3843
this.sqlParser = sqlParser;
3944
this.capacity = capacity;
45+
this.maxSQLLength = maxSQLLength;
4046
init();
4147
}
4248

@@ -48,6 +54,14 @@ public void setCapacity(Integer capacity) {
4854
this.capacity = capacity;
4955
}
5056

57+
public Integer getMaxSQLLength() {
58+
return maxSQLLength;
59+
}
60+
61+
public void setMaxSQLLength(Integer maxSQLLength) {
62+
this.maxSQLLength = maxSQLLength;
63+
}
64+
5165
public SQLParser getSqlParser() {
5266
return sqlParser;
5367
}
@@ -62,6 +76,9 @@ public void setSqlParser(SQLParser sqlParser) {
6276
*/
6377
@Override
6478
public SQLParsedState parse(String sql, ShardRouter shardRouter) {
79+
if (maxSQLLength != null && sql.length() > maxSQLLength) {
80+
return sqlParser.parse(sql, shardRouter);
81+
}// else
6582
init();
6683
InnerQueryKey queryKey = new InnerQueryKey(sql, shardRouter);
6784
SQLParsedState result = cache.get(queryKey);

‎ddal-jsqlparser/src/main/java/org/hellojavaer/ddal/jsqlparser/JSQLParserAdapter.java‎

Lines changed: 38 additions & 41 deletions
Original file line numberDiff line numberDiff line change
@@ -248,8 +248,8 @@ public SQLParsedResult parse(final Map<Object, Object> jdbcParams) {
248248
final SQLParsedResult result = new SQLParsedResult() {
249249

250250
@Override
251-
public void checkIfCrossPreparedStatement(Map<Object, Object> jdbcParam)
252-
throws CrossPreparedStatementException {
251+
public void checkIfCrossPreparedStatement(final Map<Object, Object> jdbcParams)
252+
throws CrossPreparedStatementException {
253253
for (Map.Entry<TableWrapper, String> entry : convertedTables.entrySet()) {
254254
TableWrapper tab = entry.getKey();
255255
route1(tab, jdbcParams, entry.getValue(), this.getSql());
@@ -322,18 +322,11 @@ private ShardRouteInfo route1(TableWrapper tab, Map<Object, Object> jdbcParams,
322322
+ sql + "]");
323323
}
324324
routeInfo = getRouteInfo(tab, sdValue);
325-
String next = routeInfo.toString();
325+
String newRoutedFulltableName = routeInfo.toString();
326326
if (routedFullTableName == null) {
327-
routedFullTableName = next;
327+
routedFullTableName = newRoutedFulltableName;
328328
} else {
329-
if (!routedFullTableName.equals(next)) {
330-
throw new AmbiguousRouteResultException("In sql[" + sql + "], table:'"
331-
+ tab.getOriginalConfig().toString()
332-
+ "' has multiple routing results["
333-
+ routedFullTableName + "," + next
334-
+ "]. Jdbc parameter is "
335-
+ DDRJSONUtils.toJSONString(jdbcParams));
336-
}
329+
verifyRoutedFullTableName(tab, jdbcParams, routedFullTableName, routedSql, newRoutedFulltableName);
337330
}
338331
} else {// range
339332
RangeParam rangeParam = (RangeParam) sqlParam;
@@ -356,7 +349,10 @@ private ShardRouteInfo route1(TableWrapper tab, Map<Object, Object> jdbcParams,
356349
if (end.isJdbcParamType()) {
357350
Number number = (Number) jdbcParams.get(end.getValue());
358351
if (number == null) {
359-
352+
throw new IllegalSQLParameterException("Jdbc parameter can't be null. Jdbc parameter key is "
353+
+ end.getValue() + ", jdbc parameter is "
354+
+ DDRJSONUtils.toJSONString(jdbcParams)
355+
+ " and sql is [" + sql + "]");
360356
}
361357
e0 = number.longValue();
362358
} else {
@@ -368,32 +364,35 @@ private ShardRouteInfo route1(TableWrapper tab, Map<Object, Object> jdbcParams,
368364
if (routedFullTableName == null) {
369365
routedFullTableName = next;
370366
} else {
371-
if (!routedFullTableName.equals(next)) {
372-
if (routedSql != null) {
373-
throw new CrossPreparedStatementException("Sql[" + sql + "] has been routed to ["
374-
+ routedSql + "] and table:'"
375-
+ tab.getOriginalConfig().toString()
376-
+ "' has been route to '" + routedFullTableName
377-
+ "'. But current jdbc parameter:"
378-
+ DDRJSONUtils.toJSONString(jdbcParams)
379-
+ " require route to " + next
380-
+ DDRJSONUtils.toJSONString(jdbcParams));
381-
} else {
382-
throw new AmbiguousRouteResultException("In sql[" + sql + "], table:'"
383-
+ tab.getOriginalConfig().toString()
384-
+ "' has multiple routing results["
385-
+ routedFullTableName + "," + next
386-
+ "]. Jdbc parameter is "
387-
+ DDRJSONUtils.toJSONString(jdbcParams));
388-
}
389-
}
367+
verifyRoutedFullTableName(tab, jdbcParams, routedFullTableName, routedSql, next);
390368
}
391369

392370
}
393371
}
394372
return routeInfo;
395373
}
396374

375+
private void verifyRoutedFullTableName(TableWrapper tab, Map<Object, Object> jdbcParams,
376+
String routedFullTableName, String routedSql, String newRoutedFulltableName) {
377+
if (!routedFullTableName.equals(newRoutedFulltableName)) {
378+
if (routedSql != null) {
379+
throw new CrossPreparedStatementException("Sql[" + sql + "] has been routed to [" + routedSql
380+
+ "] and table:'" + tab.getOriginalConfig().toString()
381+
+ "' has been route to '" + routedFullTableName
382+
+ "'. But current jdbc parameter:"
383+
+ DDRJSONUtils.toJSONString(jdbcParams)
384+
+ " require route to " + newRoutedFulltableName
385+
+ DDRJSONUtils.toJSONString(jdbcParams));
386+
} else {
387+
throw new AmbiguousRouteResultException("In sql[" + sql + "], table:'"
388+
+ tab.getOriginalConfig().toString()
389+
+ "' has multiple routing results[" + routedFullTableName + ","
390+
+ newRoutedFulltableName + "]. Jdbc parameter is "
391+
+ DDRJSONUtils.toJSONString(jdbcParams));
392+
}
393+
}
394+
}
395+
397396
private void afterVisitBaseStatement() {
398397
FrameContext context = this.getStack().pop();
399398
for (Map.Entry<String, TableWrapper> entry : context.entrySet()) {
@@ -523,6 +522,7 @@ private TableWrapper getTableFromContext(Column col) {
523522
*/
524523
private void addRoutedTableIntoContext(TableWrapper table, ShardRouteConfig routeConfig, boolean appendAlias) {
525524
FrameContext frameContext = this.getStack().peek();
525+
String scName = table.getSchemaName();
526526
String tbName = table.getName();
527527
String tbAliasName = tbName;
528528
if (table.getAlias() != null && table.getAlias().getName() != null) {
@@ -533,18 +533,17 @@ private void addRoutedTableIntoContext(TableWrapper table, ShardRouteConfig rout
533533
}
534534
}
535535
String sdKey = DDRStringUtils.toLowerCase(routeConfig.getSdKey());// sdKey可以为null,当为null时需要通过context路由
536-
if (table.getSchemaName() != null) {
536+
if (scName != null) {
537537
StringBuilder sb = new StringBuilder();
538-
sb.append(DDRStringUtils.toLowerCase(table.getSchemaName()));
538+
sb.append(DDRStringUtils.toLowerCase(scName));
539539
sb.append('.');
540540
sb.append(DDRStringUtils.toLowerCase(tbAliasName));
541541
sb.append('.');
542542
sb.append(sdKey);
543543
String key = sb.toString();
544544
putIntoContext(frameContext, key, table);
545-
putIntoContext(frameContext, key.substring(table.getSchemaName().length() + 1), table);
546-
putIntoContext(frameContext, key.substring(table.getSchemaName().length() + 2 + tbAliasName.length()),
547-
table);
545+
putIntoContext(frameContext, key.substring(scName.length() + 1), table);
546+
putIntoContext(frameContext, key.substring(scName.length() + 2 + tbAliasName.length()), table);
548547
} else {
549548
StringBuilder sb = new StringBuilder();
550549
sb.append(DDRStringUtils.toLowerCase(tbAliasName));
@@ -556,7 +555,7 @@ private void addRoutedTableIntoContext(TableWrapper table, ShardRouteConfig rout
556555
}
557556
}
558557

559-
private Object getRouteValue(Column column, Expression obj) {
558+
protected Object getRouteValue(Column column, Expression obj) {
560559
if (obj == null) {
561560
return null;
562561
}
@@ -637,9 +636,7 @@ public void visit(Between between) {
637636
s1 = e1;
638637
e1 = temp;
639638
}
640-
for (long l = s1; l <= e1; l++) {
641-
routeTable(tab, column, l);
642-
}
639+
routeTable(tab, column, new RangeShardValue(s1, e1));
643640
}
644641
}
645642

‎ddal-jsqlparser/src/test/java/org.hellojavaer.ddal.jsqlparser/JSQLParserAdapterTest.java‎

Lines changed: 110 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,17 +22,125 @@
2222
package org.hellojavaer.ddal.jsqlparser;
2323

2424
import net.sf.jsqlparser.JSQLParserException;
25+
import org.hellojavaer.ddal.core.utils.Assert;
26+
import org.hellojavaer.ddal.ddr.datasource.exception.CrossPreparedStatementException;
27+
import org.hellojavaer.ddal.ddr.shard.ShardRouter;
28+
import org.hellojavaer.ddal.ddr.shard.simple.SimpleShardParser;
29+
import org.hellojavaer.ddal.ddr.sqlparse.SQLParsedResult;
30+
import org.hellojavaer.ddal.ddr.sqlparse.SQLParsedState;
31+
import org.hellojavaer.ddal.ddr.sqlparse.exception.AmbiguousRouteResultException;
2532
import org.junit.Test;
2633

34+
import java.util.HashMap;
35+
import java.util.Map;
36+
2737
/**
2838
*
2939
* @author <a href="mailto:[email protected]">Kaiming Zou</a>,created on 2018/5/18.
3040
*/
31-
public class JSQLParserAdapterTest {
41+
public class JSQLParserAdapterTest extends BaseTestShardParser {
3242

3343
@Test
34-
public void test00() throws JSQLParserException {
44+
public void testInitCheck() throws JSQLParserException {
3545
JSQLParserAdapter.checkJSqlParserFeature();
3646
JSQLParserAdapter.checkCompatibilityWithJSqlParser();
3747
}
48+
49+
@Test
50+
public void testLimitCheck00() {
51+
String sql = "select * from user where id = ?";
52+
ShardRouter shardRouter = buildParserForId().getShardRouter();
53+
JSQLParserAdapter jsqlParserAdapter = new JSQLParserAdapter(sql, shardRouter, false);
54+
SQLParsedState sqlParsedState = jsqlParserAdapter.parse();
55+
Map<Object, Object> jdbcParams = new HashMap<>();
56+
jdbcParams.put(1, 506);
57+
SQLParsedResult sqlParsedResult = sqlParsedState.parse(jdbcParams);
58+
Assert.equals(sqlParsedResult.getSql(), "SELECT * FROM db_02.user_0122 AS user WHERE id = ?");
59+
jsqlParserAdapter = new JSQLParserAdapter(sql, shardRouter, true);
60+
try {
61+
sqlParsedState = jsqlParserAdapter.parse();
62+
throw new Error();
63+
} catch (Exception e) {
64+
}
65+
}
66+
67+
@Test
68+
public void testLimitCheck01() {
69+
String sql = "select * from user where id = ? limit 10";
70+
ShardRouter shardRouter = buildParserForId().getShardRouter();
71+
JSQLParserAdapter jsqlParserAdapter = new JSQLParserAdapter(sql, shardRouter, false);
72+
SQLParsedState sqlParsedState = jsqlParserAdapter.parse();
73+
Map<Object, Object> jdbcParams = new HashMap<>();
74+
jdbcParams.put(1, 506);
75+
SQLParsedResult sqlParsedResult = sqlParsedState.parse(jdbcParams);
76+
Assert.equals(sqlParsedResult.getSql(), "SELECT * FROM db_02.user_0122 AS user WHERE id = ? LIMIT 10");
77+
78+
jsqlParserAdapter = new JSQLParserAdapter(sql, shardRouter, true);
79+
sqlParsedState = jsqlParserAdapter.parse();
80+
jdbcParams = new HashMap<>();
81+
jdbcParams.put(1, 506);
82+
sqlParsedResult = sqlParsedState.parse(jdbcParams);
83+
Assert.equals(sqlParsedResult.getSql(), "SELECT * FROM db_02.user_0122 AS user WHERE id = ? LIMIT 10");
84+
}
85+
86+
@Test
87+
public void testSqlParsedState00() {
88+
String sql = "select * from user where id = ?";
89+
SimpleShardParser parser = buildParserForId();
90+
JSQLParserAdapter jsqlParserAdapter = new JSQLParserAdapter(sql, parser.getShardRouter(), false);
91+
SQLParsedState sqlParsedState = jsqlParserAdapter.parse();
92+
//
93+
Map<Object, Object> jdbcParams = new HashMap<>();
94+
jdbcParams.put(1, 506);
95+
SQLParsedResult sqlParsedResult = sqlParsedState.parse(jdbcParams);
96+
Assert.equals(sqlParsedResult.getSql(), "SELECT * FROM db_02.user_0122 AS user WHERE id = ?");
97+
98+
jdbcParams = new HashMap<>();
99+
jdbcParams.put(1, 507);
100+
sqlParsedResult = sqlParsedState.parse(jdbcParams);
101+
Assert.equals(sqlParsedResult.getSql(), "SELECT * FROM db_03.user_0123 AS user WHERE id = ?");
102+
}
103+
104+
@Test
105+
public void testSqlParsedState01() {
106+
String sql = "select * from user where id = ?";
107+
SimpleShardParser parser = buildParserForId();
108+
JSQLParserAdapter jsqlParserAdapter = new JSQLParserAdapter(sql, parser.getShardRouter(), false);
109+
SQLParsedState sqlParsedState = jsqlParserAdapter.parse();
110+
//
111+
Map<Object, Object> jdbcParams = new HashMap<>();
112+
jdbcParams.put(1, 506);
113+
SQLParsedResult sqlParsedResult = sqlParsedState.parse(jdbcParams);
114+
Assert.equals(sqlParsedResult.getSql(), "SELECT * FROM db_02.user_0122 AS user WHERE id = ?");
115+
//
116+
jdbcParams = new HashMap<>();
117+
jdbcParams.put(1, 507);
118+
try {
119+
sqlParsedResult.checkIfCrossPreparedStatement(jdbcParams);
120+
throw new Error();
121+
} catch (CrossPreparedStatementException e) {
122+
123+
}
124+
}
125+
126+
@Test
127+
public void testSqlParsedState02() {
128+
String sql = "select * from user where id = ? and id = 506";
129+
SimpleShardParser parser = buildParserForId();
130+
JSQLParserAdapter jsqlParserAdapter = new JSQLParserAdapter(sql, parser.getShardRouter(), false);
131+
SQLParsedState sqlParsedState = jsqlParserAdapter.parse();
132+
//
133+
Map<Object, Object> jdbcParams = new HashMap<>();
134+
jdbcParams.put(1, 506);
135+
SQLParsedResult sqlParsedResult = sqlParsedState.parse(jdbcParams);
136+
Assert.equals(sqlParsedResult.getSql(), "SELECT * FROM db_02.user_0122 AS user WHERE id = ? AND id = 506");
137+
//
138+
jdbcParams = new HashMap<>();
139+
jdbcParams.put(1, 507);
140+
try {
141+
sqlParsedState.parse(jdbcParams);
142+
throw new Error();
143+
} catch (AmbiguousRouteResultException e) {
144+
}
145+
}
38146
}

0 commit comments

Comments
 (0)