Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start Adding actual Content #52

Open
fahad-israr opened this issue Aug 11, 2020 · 16 comments · Fixed by #59
Open

Start Adding actual Content #52

fahad-israr opened this issue Aug 11, 2020 · 16 comments · Fixed by #59

Comments

@fahad-israr
Copy link
Member

  • As data is entered using JSON you need fill in there itself
  • Match content to iiitt.ac.in
@fahad-israr
Copy link
Member Author

@thisisnitish You may want to start here
A good start to understand the structure and get started.
Start with filling content from home page.

@thisisnitish
Copy link
Contributor

So what I need to do please explain some more so that I'll have a clear idea🙂

@thisisnitish
Copy link
Contributor

Actually I was adding the actual content from the old website, I found that how we will render the docs like there is some file called notice.json, so how we will render the pdf docs.
Screenshot 2020-08-12 at 6 36 01 PM

@fahad-israr
Copy link
Member Author

Currently, we are downloading the pdf on the user's machine......We tried rendering on-screen using pdf viewer but had issues so we are going with the way older iiitt.ac.in behaves on that context.

@thisisnitish
Copy link
Contributor

okk fine😊

@fahad-israr
Copy link
Member Author

So what I need to do please explain some more so that I'll have a clear idea🙂

For example news, notice,events etc is using a placeholder. Use real content.
Also, try uploading real pictures in slider

@thisisnitish
Copy link
Contributor

okk😊

@thisisnitish
Copy link
Contributor

Screenshot 2020-08-20 at 11 12 05 PM

1 .There is same pdf doc for both the notices. For the above one it is correct I guess because doc name is same as notice name but for the second one it is redirect to the same pdf doc.So what to do?

Screenshot 2020-08-20 at 11 12 48 PM

2. There is not page redirecting to the pdf doc. So what to do?

@fahad-israr
Copy link
Member Author

Do the same..add the same file...
and link the same to both...
we're kinda focussing on cloning the website....
Also there are contents like COVID-19 Notice-10 ,COVID-19 Notice-9 etc...Rename them to something more clear like which conveys something about the information conveyed.

@fahad-israr
Copy link
Member Author

Reopening Issue as more content to add.

@fahad-israr fahad-israr reopened this Aug 24, 2020
@thisisnitish
Copy link
Contributor

  • while adding the actual dates for all the documents, I found that so many notices which doesn't have date mentioned in it. So what to do for that, suggest me

@fahad-israr
Copy link
Member Author

  • I'd say that use approximations so that the order of sorting is maintained ;)

@thisisnitish
Copy link
Contributor

  • Ok, so for those notices which don't have dates mentioned in it I will use approximate date

@thisisnitish
Copy link
Contributor

thisisnitish commented Aug 26, 2020

  • You know what, there are so many notices in the old section and those were issued in 2020 and, all the notices in the new section were issued in 2020 too. So there is a conflict occurring while listing those notices.
  • I added dates to all those notices in which dates were not mentioned, by asking some people and by observing that when these notices were issued for the students.
  • The issue is conflict between the old notices and new notices listing which were issued in the same year 2020, Other than that everything is fine.
  • Now, what should I do? Should I send pr because I think at the end we will resolve this bug too but as of now we have all the notices with almost right data.😊

@fahad-israr
Copy link
Member Author

Good Work!!
you can create a PR

@fahad-israr
Copy link
Member Author

Hey @thisisnitish the CI/CD has been updated for you as well.
Every time you create a PR you'll result will be built and deployed to https://iiittn.surge.sh/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants