From 6930ae8e9b30df5b66b36af291de4577962051b5 Mon Sep 17 00:00:00 2001 From: Carlos Tadeu Panato Junior Date: Thu, 28 Jul 2022 10:14:12 +0200 Subject: [PATCH] update action to default chart-testing install to v3.7.0 (#94) Signed-off-by: cpanato --- .github/workflows/test-action.yml | 26 +++++++++++++++++++++++--- README.md | 6 +++--- action.yml | 4 ++-- ct.sh | 2 +- 4 files changed, 29 insertions(+), 9 deletions(-) diff --git a/.github/workflows/test-action.yml b/.github/workflows/test-action.yml index 7d6fdf9..5f636b1 100644 --- a/.github/workflows/test-action.yml +++ b/.github/workflows/test-action.yml @@ -12,7 +12,17 @@ jobs: - name: Install chart-testing uses: ./ - name: Check install! - run: ct version + run: | + ct version + CT_VERSION_OUTPUT=$(ct version 2>&1 /dev/null) + ACTUAL_VERSION=$(echo "$CT_VERSION_OUTPUT" | grep Version | rev | cut -d ' ' -f1 | rev) + if [[ $ACTUAL_VERSION != 'v3.7.0' ]]; then + echo 'should be v3.7.0' + exit 1 + else + exit 0 + fi + shell: bash - name: Check root directory run: | if [[ $(git diff --stat) != '' ]]; then @@ -31,9 +41,19 @@ jobs: - name: Install chart-testing uses: ./ with: - version: 'v3.4.0' + version: 'v3.5.1' - name: Check install! - run: ct version + run: | + ct version + CT_VERSION_OUTPUT=$(ct version 2>&1 /dev/null) + ACTUAL_VERSION=$(echo "$CT_VERSION_OUTPUT" | grep Version | rev | cut -d ' ' -f1 | rev) + if [[ $ACTUAL_VERSION != 'v3.5.1' ]]; then + echo 'should be v3.5.1' + exit 1 + else + exit 0 + fi + shell: bash - name: Check root directory run: | if [[ $(git diff --stat) != '' ]]; then diff --git a/README.md b/README.md index 0b8eb8e..f6511c9 100644 --- a/README.md +++ b/README.md @@ -15,7 +15,7 @@ A GitHub Action for installing the [helm/chart-testing](https://github.com/helm/ For more information on inputs, see the [API Documentation](https://developer.github.com/v3/repos/releases/#input) -- `version`: The chart-testing version to install (default: `v3.5.0`) +- `version`: The chart-testing version to install (default: `v3.7.0`) ### Example Workflow @@ -42,7 +42,7 @@ jobs: - name: Set up Helm uses: azure/setup-helm@v1 with: - version: v3.8.1 + version: v3.9.2 - uses: actions/setup-python@v2 with: @@ -70,7 +70,7 @@ jobs: run: ct install ``` -This uses [`helm/kind-action`](https://www.github.com/helm/kind-action) GitHub Action to spin up a [kind](https://kind.sigs.k8s.io/) Kubernetes cluster, +This uses [`helm/kind-action`](https://www.github.com/helm/kind-action) GitHub Action to spin up a [kind](https://kind.sigs.k8s.io/) Kubernetes cluster, and [`helm/chart-testing`](https://www.github.com/helm/chart-testing) to lint and test your charts on every pull request. ## Upgrading from v1.x.x diff --git a/action.yml b/action.yml index ca462de..4d16da7 100644 --- a/action.yml +++ b/action.yml @@ -6,9 +6,9 @@ branding: icon: anchor inputs: version: - description: "The chart-testing version to install (default: v3.5.1)" + description: "The chart-testing version to install (default: v3.7.0)" required: false - default: v3.5.1 + default: v3.7.0 runs: using: composite steps: diff --git a/ct.sh b/ct.sh index 3ed9b5c..36cf6e4 100755 --- a/ct.sh +++ b/ct.sh @@ -4,7 +4,7 @@ set -o errexit set -o nounset set -o pipefail -DEFAULT_CHART_TESTING_VERSION=v3.5.1 +DEFAULT_CHART_TESTING_VERSION=v3.7.0 show_help() { cat << EOF