Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possibly high cardinality on chartmuseum_requests_total labels #448

Open
jayme-github opened this issue Apr 14, 2021 · 0 comments · May be fixed by #789
Open

Possibly high cardinality on chartmuseum_requests_total labels #448

jayme-github opened this issue Apr 14, 2021 · 0 comments · May be fixed by #789

Comments

@jayme-github
Copy link
Contributor

It is currently possible to request arbitrary URLs from chartmuseum which will not be normalized via mapURLWithParamsBackToRouteTemplate(). This means that someone with evil intentions could add a high level of cardinality to that metric leading to potential issues with prometheus.

See zsais/go-gin-prometheus#36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

router: fix prometheus metrics high cardinality issue helm/chartmuseum
1 participant
@jayme-github