Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error on new helm deployment #83

Open
atedsimple opened this issue Nov 18, 2022 · 5 comments
Open

Error on new helm deployment #83

atedsimple opened this issue Nov 18, 2022 · 5 comments
Labels
question Further information is requested

Comments

@atedsimple
Copy link

Firstly I love this plugin, it has saved us so much pain

One thing though, when we start a new service that has never been deployed to AKS, it generates and error. It doesn't really make sense for this to be an error situation though

image

@hickeyma
Copy link
Contributor

@atedsimple Its hard to know what is causing this. Would you be able to troubleshoot this further and provide more details?

@hickeyma hickeyma added the question Further information is requested label Jan 18, 2023
@atedsimple
Copy link
Author

Well it happens only when the service isn't already deployed to the cluster

@hickeyma
Copy link
Contributor

@atedsimple What "service" are you referring to? Is this some service that you deploy using Helm?

@atedsimple
Copy link
Author

Yeah. We create a service, package it up with Helm and deploy it to our AKS cluster. If the service is already deployed to our AKS cluster then Helm will upgrade it. However the upgrade will only work if there is a valid rollback path, so the current Helm deployment in the AKS cluster needs to be valid. Normally it is, however, if the AKS cluster has been upgraded then sometimes there is a breaking change to one of the AKS System API's so current Helm deployments become invalid. The actual services running within the cluster are fine, but the files used by Helm to deploy that version are not so any Helm upgrade of that service will fail as there is no valid rollback path. The mapkubeapis plugin is great as it detects and fixes these issues that are present in the current Helm deployment files so that the Helm upgrade that we are trying to run will work. However, if there is no current deployment present in the cluster then mapkubeapis generates an error. It would be better if it didn't generate an error as this will fail a DevOps Pipeline unless, of course, you set the Ignore Errors flag but then you get an unnecessary warning icon.

@hickeyma
Copy link
Contributor

hickeyma commented Mar 7, 2023

I can see your use case alright. Not really sure the best approach to do this as it handled by the error handling and cobra cli.

Another approach might be if you check for the release first before calling the tool?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants