Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix web site scrolling on mobile browsers #1535

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix web site scrolling on mobile browsers #1535

wants to merge 2 commits into from

Commits on Dec 9, 2023

  1. Fix web site scrolling on mobile browsers 

    Scrolling pages on the Helm web site is difficult on mobile devices due
to nested scrolling containers. This changeset removes the nested
scrolling containers.

The fix to remove the nested scrolling containers caused pages to start
scrolling horizontally because the content of the pages have negative
margins, which makes the page wider than 100%. The rest of this
changeset addresses the negative margins by removing them and/or
offsetting them in each element that was causing the page to horizontal
scroll.

Fixes helm#741
Fixes helm#1393
Fixes helm#1464

Signed-off-by: Matt Light <[email protected]>
    @lightster
    lightster committed Dec 9, 2023
    Configuration menu
    Copy the full SHA
    7bd3411 View commit details
    Browse the repository at this point in the history

  2. Remove unnecessary DOM element 

    Signed-off-by: Matt Light <[email protected]>
    @lightster
    lightster committed Dec 9, 2023
    Configuration menu
    Copy the full SHA
    14ed7c2 View commit details
    Browse the repository at this point in the history