Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Including tests+docs in sizing discourages both #9

Open
glb opened this issue Nov 28, 2019 · 0 comments
Open

Including tests+docs in sizing discourages both #9

glb opened this issue Nov 28, 2019 · 0 comments

Comments

@glb
Copy link

glb commented Nov 28, 2019

I’ve found on multiple occasions that adding unit tests or docs to a PR (or a PR that’s literally just unit tests) almost instantly bumps the PR into needing a +2 because of the size.

While the team is awesome about this, it seems like this almost discourages writing docs and tests.

I doubt there’s any appetite for changing how the bot does its calculations, but I thought I’d raise the topic in the hopes that maybe someone could educate me as to the benefits / rationale for the current method, or maybe it would stimulate some conversation about alternate strategies.

Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant