Add base64 encoding support to file provider #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skokhanovskiy
requested review from
mumoshu,
itscaro,
yxxhero and
xiaomudk
as code owners
skokhanovskiy
force-pushed
the
feature/add-file-base64-encoding
branch
2 times, most recently
from
7feca6c to
6fbc3e4
Compare
added 2 commits
September 16, 2023 18:21
Signed-off-by: Stepan Kokhanovskiy <[email protected]>
Signed-off-by: Stepan Kokhanovskiy <[email protected]>
skokhanovskiy
force-pushed
the
feature/add-file-base64-encoding
branch
from
6fbc3e4 to
8f03bb7
Compare
|
@skokhanovskiy add some unit-tests will be better. |
Signed-off-by: Stepan Kokhanovskiy <[email protected]>
|
@yxxhero I've added some tests for both |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #163.