Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: UserWarning: TypedStorage is deprecated. #1229

Closed
ClaudiaComito opened this issue Oct 6, 2023 · 2 comments
Closed

[Bug]: UserWarning: TypedStorage is deprecated. #1229

ClaudiaComito opened this issue Oct 6, 2023 · 2 comments
Assignees
Labels
bug Something isn't working interoperability types

Comments

@ClaudiaComito
Copy link
Contributor

What happened?

We have a few torch.Tensor.storage() calls across the codebase, most notably in the communication module. PyTorch raises the following warning (see below).

Update code wherever needed (call Tensor.untyped_storage() instead of Tensor.storage(), check for backward compatibility).

Code snippet triggering the error

No response

Error message or erroneous outcome

UserWarning: TypedStorage is deprecated. It will be removed in the future and UntypedStorage will be the only storage class. This should only matter to you if you are using storages directly.  To access UntypedStorage directly, use tensor.untyped_storage() instead of tensor.storage()

Version

1.3.x

Python version

None

PyTorch version

None

MPI version

No response

@ClaudiaComito ClaudiaComito added the bug Something isn't working label Oct 6, 2023
@mrfh92 mrfh92 self-assigned this Oct 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2023

@mrfh92
Copy link
Collaborator

mrfh92 commented Oct 13, 2023

Resolved by merging #1230

Note: since this will only become an actual bug when deprecation actually happens in a future PyTorch release, we handeled our adaptations as "feature" instead of "bug", i.e. #1230 has been merged into main (development version) instead of a bug fix version of the current release.

@mrfh92 mrfh92 closed this as completed Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working interoperability types
Projects
None yet
Development

No branches or pull requests

2 participants