-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
language mixup on traffic #5
Comments
Please don't create issues like this. As a rule, I don't ever feel inclined to go out of my way for people who verbally abuse maintainers. I made this library because we needed it, I'm glad others get value from it too. If you're going to use our libs, great. If you want to create issues and let us know when there is a bug, awesome. If you want to do a pr, that's fantastic. But please do not create issues to be condescending and hostile. We have a very simple policy of blocking people who are hostile and create negative energy (when we block, we block the personal across all of our libraries and orgs). Normally I would have already done this by now, but I'll assume you're having a bad day. Moreover:
Simply stating the problem is enough. I'm betting the vast majority of users just use the for dates, not i18n (think about it). |
Alright, it was definitely not meant to be offensive. |
moment.locale(opts.lang || opts.language);
being called before calling the
moment()
function is problematic.This will force you to use one language throughout your templates, i fixed it in a branch i'm currently using by sending the language as the 3rd parameter in the
moment()
function instead.Note: The problems won't appear until you have considerable traffic and using multiple locales, the locales would get mixed up.
Best,
Ayman.
The text was updated successfully, but these errors were encountered: