Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

language mixup on traffic #5

Open
aymanc opened this issue Sep 9, 2017 · 2 comments
Open

language mixup on traffic #5

aymanc opened this issue Sep 9, 2017 · 2 comments

Comments

@aymanc
Copy link

aymanc commented Sep 9, 2017

moment.locale(opts.lang || opts.language);
being called before calling the moment() function is problematic.

This will force you to use one language throughout your templates, i fixed it in a branch i'm currently using by sending the language as the 3rd parameter in the moment() function instead.

Note: The problems won't appear until you have considerable traffic and using multiple locales, the locales would get mixed up.

Best,
Ayman.

@jonschlinkert
Copy link
Member

Please don't create issues like this. As a rule, I don't ever feel inclined to go out of my way for people who verbally abuse maintainers.

I made this library because we needed it, I'm glad others get value from it too. If you're going to use our libs, great. If you want to create issues and let us know when there is a bug, awesome. If you want to do a pr, that's fantastic. But please do not create issues to be condescending and hostile. We have a very simple policy of blocking people who are hostile and create negative energy (when we block, we block the personal across all of our libraries and orgs). Normally I would have already done this by now, but I'll assume you're having a bad day.

Moreover:

  • please use backticks around code examples
  • please use a title that describes the actual bug you experienced. the current title is not informative.
  • If you found a bug, and you took the time to figure out the cause, and it was something this simple, it would have taken less time to just submit a pr instead of typing out the entire rant. Now I'm having to respond to the rant instead of coding. See how this negative energy destroys productivity?

This will force you to use one language throughout your templates (think about it),

Simply stating the problem is enough. I'm betting the vast majority of users just use the for dates, not i18n (think about it).

@aymanc aymanc changed the title Please don't do this language mixup on traffic Sep 10, 2017
@aymanc
Copy link
Author

aymanc commented Sep 10, 2017

Alright, it was definitely not meant to be offensive.

@aymanc aymanc closed this as completed Sep 10, 2017
@aymanc aymanc reopened this Sep 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants