Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scroll bottom doesnt get triggered if body is to short #1

Open
netlane opened this issue Apr 26, 2017 · 0 comments
Open

scroll bottom doesnt get triggered if body is to short #1

netlane opened this issue Apr 26, 2017 · 0 comments

Comments

@netlane
Copy link

netlane commented Apr 26, 2017

Hi!
If a page is not that long, the scroll bottom event may not always fire.
I made a change so that bottom doesnt rely on bodyHeight - 15% but rather use bodyHeight - windowHeight

line 120:
if ('scroll' === settings[thisId].method) {
var windowHeight = window.innerHeight
|| document.documentElement.clientHeight
|| document.body.clientHeight;
var bodyHeight = document.body.offsetHeight,
middle = parseInt(bodyHeight/2),
bottom = bodyHeight - windowHeight - 10;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant