Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hemelb::redblood::orientFacets gives inconsistent results when loading deformed mesh #735

Open
mobernabeu opened this issue Mar 12, 2020 · 4 comments
Assignees

Comments

@mobernabeu
Copy link
Contributor

As part of #733, @Romain-Enjalbert found that hemelb::redblood::orientFacets will reorder 719 out 720 facets for a mesh that we know has consistent facet orientation throughout.

mobernabeu added a commit that referenced this issue Mar 12, 2020
@mobernabeu
Copy link
Contributor Author

3f7ea8e adds a failing test.

@Romain-Enjalbert, if you make all and run ./unittests_redblood hemelb::unittests::redblood::LoadingTimmMeshTests you should see 1 test out of 3 failing (see new code in previous commit for an explanation of what each of the tests does). The idea would be for us to provide a new implementation of hemelb::redblood::orientFacets that makes all three tests pass. This gives you a very fast an automated way of checking that the new code does what's expected from it in all three cases we have discussed this week.

@mobernabeu
Copy link
Contributor Author

orientFacets method for meshes constructed from a .msh file has been deprecated. A more robust implementation based on VTK provided in a4764ed. We should use VTK input files from now on.

@rupertnash rupertnash reopened this Feb 9, 2021
@rupertnash
Copy link
Member

Hi @mobernabeu - you have added a failing test to the build. Can we remove this test as deprecated? Can we remove some code?

@mobernabeu
Copy link
Contributor Author

Yes, we should remove the failing test and the support for .msh files altogether from the code as our implementation of orientFacets for them is subpar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants