Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paginate PoP Payouts Response #195

Closed
1 task done
ClaytonNorthey92 opened this issue Aug 2, 2024 · 3 comments · Fixed by #196
Closed
1 task done

Paginate PoP Payouts Response #195

ClaytonNorthey92 opened this issue Aug 2, 2024 · 3 comments · Fixed by #196
Assignees
Labels
area: bfg This is a change to BFG (Bitcoin Finality Governor) area: bss This is a change to BSS (Bitcoin Secure Sequencer) status: in review This has been resolved by a pull request that is awaiting review type: enhancement This improves existing functionality

Comments

@ClaytonNorthey92
Copy link
Contributor

Confirmation

  • I have checked for similar issues.

Problem

When op-node requests pop payouts, we need to paginate because this response is large and will not scale.

If I am not mistaken, this will require pagination in both bss and bfg getting pop payouts responses.

Suggested solution

paginate bss and bfg pop payouts/pop tx responses when op node requests them

Additional Information

No response

@ClaytonNorthey92 ClaytonNorthey92 added type: enhancement This improves existing functionality area: bfg This is a change to BFG (Bitcoin Finality Governor) area: bss This is a change to BSS (Bitcoin Secure Sequencer) labels Aug 2, 2024
@ClaytonNorthey92 ClaytonNorthey92 self-assigned this Aug 2, 2024
@joshuasing
Copy link
Contributor

@ClaytonNorthey92 Is this a duplicate of, or similar to #193?

@ClaytonNorthey92 ClaytonNorthey92 added the status: in review This has been resolved by a pull request that is awaiting review label Aug 5, 2024
@ClaytonNorthey92
Copy link
Contributor Author

hey @joshuasing it's a duplicate essentially, the only difference is that I added the pagination through BSS as well (so the full call path op-node -> bss -> bfg can be paginated)

@joshuasing joshuasing changed the title Paginate Pop Payouts Response Paginate PoP Payouts Response Aug 5, 2024
@Syuraih7

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: bfg This is a change to BFG (Bitcoin Finality Governor) area: bss This is a change to BSS (Bitcoin Secure Sequencer) status: in review This has been resolved by a pull request that is awaiting review type: enhancement This improves existing functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants