-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No editing menu displayed on Mac Mojave #19
Comments
I don't have Mac myself, so can't test this, but:
The only obvious question is that you need a recent (like last 12-18 months) version of the official demo. (More precisely, 1.0 version or newer of the impress.js file.) These are known to work: https://github.com/henrikingo/impressionist-templates/tree/master/official-demo Just in case you never saw it work, this is what it should look like: https://youtu.be/c07w0hsC4yQ?t=243 |
@henrikingo , I did try moving the missing files from other folders in to the specified locations, but this results in another error. |
Ok thanks for this info. I'll look into this. |
I had the chance to look into this a couple weeks ago. It turns out on Linux this actually works correctly. But based on the information you provided, I know that this is the suspect line: Line 47 in 5779397
It seems electron does different things for Thanks for your patience! UPDATE: This comment is wrong. The errors above are not from |
Here is how it worked for me on MacOS Mojave. Caution, I didn't test if that will break functionality on other platforms!
|
same problem on ubuntu 18.04.02: |
Running a beta of MacOS Catalina: I found I also had to change the path (same, two levels back) in line 1568 and line 1112 of impressionist.js Oh to save people not familiar with the dev tools looking up how to enable them you add mainWindow.webContents.openDevTools() just after the new BrowserWindow on line 12/13 of main.js Then once you have loaded they slides, you can examine the console to see if it couldn't find the correct resources. |
Hi Sorry to keep everyone waiting. While I'm quite excited about the possibilities for Impressionist, I have been prioritizing incoming PRs in impress.js side. After all, that's a widely used and stable project while this is still experimental. But now it is Summer and I finally do have some time for Impressionist. As a first step I committed upgrade to electron. However, after looking around a bit, it seems to me this is not an electron version issue and if you retry That said, feel free to retry and let me know how it goes. |
Ok. Above commit avoids using Please also test typing on a slide. I worry that tinymce installation path may not always be the same for everyone. |
After I run

npm start
, a blank screen appears.I've read from somewhere that this is intended. So, I open the official demo. The demo appears, but I can't see any editing menus at the top.

Can anyone please help? How can I make the editing menu to be displayed?
I am using macOS Mojave (Version 10.14)
The text was updated successfully, but these errors were encountered: