Similiar paths ending with a different static part are not handled properly

[lexor90]

Let's have

´/:user_id/:id/photosand/:user_id/:id/pagesboth responding to the same method, let's sayPOST`.

The router will follow the structure only of the first matching path, so when coming to the last staticPath it will find either photos or pages (according to what has been declared first) and return 404, making them not usable togheter.

Example:

app.post('/:user_id/:id/pages', function (req, res) {...});
app.post('/:user_id/:id/photos', function (req, res) { ... });

POST /abc/def/pages -> 200 OK
POST /abc/def/photos -> 404 Not Found

I tried to remake it by changing the initial structure to merge toghether static paths under the same dynamic route, but it would not work if :user_id becomes something else.
It should be implemented a runtime logic to try all matching paths, so if the first one fails, but the structure has some other dynamicPath with '3' parts it should also try them before to fail with a not found.

Any idea of how this could be implemented in your logic?

BTW, thanks for this useful library!

[lexor90]

As of my understanding it should be implemented inside router.js where

table = table.dynamicRoutes[size]

if size is greater than 1 instead of simply return notFound(req, res) we should be able to reduce the original table by the already parsed element (e.g. delete table[justLoopedItem]) and remake the logic with the new table that is reduced by one item (remake the whole continue_to_next_value loop).

This will introduce worse performances if multiple paths are using the same method/structure, but sometimes, especially for RESTful webservices, route design is not a matter of choice and the /:parent/:child URL structuring is just better than /somenamespacetomakeitwork/:parent/:child.

[lexor90]

Hello @herenow any news about this? I could work on a patch if you would give to me some feedback on what should be the best way to achieve this.

Thanks.

[herenow]

I'm going to send in a patch today :)

[herenow]

I tried to fix this on #3

But I can't seem to figure an easy way to solve it, without refactoring the whole thing. Unfortunately I won't have time for this.

I don't plan on maintaining this project any further, it was just an experiment at the time.

I urge you to use another router if you need this kind of routes.

Feel free to send PR's though, if you wan't to fix this issue, I'm not sure how to fix it though :)

[herenow]

@lexor90 Actually, I gave the problem a rest, and my fix actually works. Although it may not be elegant.