Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support maxNumBatch and atomic transactions #152

Open
krlosMata opened this issue May 4, 2021 · 2 comments
Open

Support maxNumBatch and atomic transactions #152

krlosMata opened this issue May 4, 2021 · 2 comments
Assignees
Labels
type: enhancement Performance enhancement, refactor...

Comments

@krlosMata
Copy link
Contributor

New features

maxNumBatch

Allow the user to sign a maxNumBatch parameter when sending a L2 transaction.

  • Proposals implementation:
    • Add new param to transaction maxNumBatch which would be chosen by the user
    • Add numBatchOffset and internally compute the maxNumBatch

Atomic transactions

All the rq should be added to allow the user to link transactions.

  • Proposals implementation:
    • when a L2 transaction is done, return the necessary data which could be shared afterwards to link transactions. Therefore allow a single object as a parameter to link transactions
    • Add single parameters just related to atomic transactions and sign them internally
@krlosMata krlosMata added the type: enhancement Performance enhancement, refactor... label May 4, 2021
@krlosMata
Copy link
Contributor Author

maxNumBatch feature implemented in #159

@krlosMata
Copy link
Contributor Author

krlosMata commented May 11, 2021

We would go for the following implementations:

maxNumBatch

Add new param to transaction maxNumBatch which would be chosen by the user

Atomic transactions

Add single parameter (linkedTransaction) just related to atomic transaction and sign them internally.
We will review user/develop flow afterwards and select the best way to incorporate atomic transaction data in higher layer in the library

@krlosMata krlosMata self-assigned this May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Performance enhancement, refactor...
Projects
None yet
Development

No branches or pull requests

1 participant