-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hello_world performance regression #97
Comments
Hm, difficult to say. I looked in the history and it changed a lot. For instance, I revised the Interface to the PCI drivers and its initialization. We should create a process to monitor the performance changes. |
I guess just building old version from git is a reasonable way to identify when it happened. Chances are, that it is just a bug as it seems not to be related to any of the features. Or maybe the features are not yet implemented perfectly. Anyhow, git bisect[0] should be able to help. even though I am not sure how well it works with submodules. |
So, I gave it a try, but I failed to build old versions of this repo. Here is what I did:
Is that fine or am I missing something? When I follow these steps I get
|
The execution time of hello_world degraded by about 13% over the last several month.
Version checked in the uhyve repo:
Current master version with all features enabled, i.e. fsgsbase, pci, acpi:
Current master version with pci and acpi enabled:
Current master version with pci enabled:
Current master version with acpi enabled:
It seems to be that regardless of which feature is enabled, execution time is slower than it used to be and I am not sure why it is. The version checked in the uhyve repo seems to have at least pci enabled:
The text was updated successfully, but these errors were encountered: