Skip to content
This repository was archived by the owner on Apr 29, 2022. It is now read-only.
This repository was archived by the owner on Apr 29, 2022. It is now read-only.

KeyError is silenced if thrown from inner handler #37

Open
@lenolib

Description

@lenolib

If a KeyError is thrown in the handler, it will be caught and no log output will be produced. It bit me and it took some time to figure out what was happening.
Proposed fix: try-except-KeyError only the environ lookup.

https://github.com/kennethreitz/flask-sockets/blob/master/flask_sockets.py#L47

        except (NotFound, KeyError):
            return self.wsgi_app(environ, start_response)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions