From c7e5206881479e4656814553300a015d2c143923 Mon Sep 17 00:00:00 2001 From: Schneems Date: Wed, 6 Mar 2024 16:49:22 -0600 Subject: [PATCH 1/5] Update README and documentation --- CONTRIBUTING.md | 142 +++++++++++++++++++ README.md | 263 +++++++---------------------------- docs/application_contract.md | 82 +++++++++++ docs/upgrading.md | 14 ++ 4 files changed, 286 insertions(+), 215 deletions(-) create mode 100644 CONTRIBUTING.md create mode 100644 docs/application_contract.md create mode 100644 docs/upgrading.md diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md new file mode 100644 index 00000000..7ad60d85 --- /dev/null +++ b/CONTRIBUTING.md @@ -0,0 +1,142 @@ +# Contributing Guide for Heroku Cloud Native Buildpacks + +This page lists the operational governance model of this project, as well as the recommendations and requirements for how to best contribute to Heroku Cloud Native Buildpacks. We strive to obey these as best as possible. As always, thanks for contributing. + +## Governance Model: Salesforce Sponsored + +The intent and goal of open sourcing this project is to increase the contributor and user base. However, only Salesforce employees will be given `admin` rights and will be the final arbitrars of what contributions are accepted or not. + +## Getting started + +Please feel free to join the [Heroku Cloud Native Buildpacks discussions][discussions]. You may also wish to take a look at [Heroku's product roadmap][roadmap] to see where are headed. + +## Ideas and Feedback + +The `heroku/ruby` buildpack is user centered software focused on application developers. To improve the application developer experience, we need to get real world feedback. We are interested in failure stories "what could be better," success stories "what went well," and your experiences in general. + +Please use [Heroku Cloud Native Buildpacks discussions][discussions] to provide feedback, request enhancements, or discuss ideas. + +## Issues, Feature Requests, and Bug Reports + +Issues should be for bugs in buildpack behavior, and not for general "my application has a problem" support. You can share your experiences building with the heroku/ruby CNB on our [discussions][discussions]. If you're unsure about whether or not to file an issue, please review the [application contract](docs/application_contract.md). + +Issues, feature requests, and bug reports are tracked via [GitHub issues on this repository][issues]. If you find an issue and/or bug, please search the issues, and if it isn't already tracked, create a new issue. Please describe the expected behavior, actual behavior, and why the two did not align. If possible, include an [example application that reproduces the problem](https://www.codetriage.com/example_app). + +## Fixes, Improvements, and Patches + +Fixes, improvements, and patches all happen via [GitHub Pull Requests on this repository][pulls]. If you'd like to improve the tests, you want to make the documentation clearer, you have an alternative implementation of something that may have advantages over the way its currently done, or you have any other change, we would be happy to hear about it. For trivial changes, send a pull request. For non-trivial changes, consider [opening an issue](#issues-feature-requests-and-bug-reports) to discuss it first instead. + +## Development + +### Dependencies + +This buildpack relies on [heroku/libcnb.rs][libcnb] to compile buildpacks. All [libcnb.rs dependencies][libcnb-deps] will need to be setup prior to building or testing this buildpack. + +1. Install [rust by following instructions on their site](https://www.rust-lang.org/tools/install) +1. Follow the setup instructions on [heroku/libcnb](https://github.com/heroku/libcnb.rs) +1. Install the [pack cli](https://buildpacks.io/docs/for-platform-operators/how-to/integrate-ci/pack/) + +### Building the buildpack locally + +1. Run `cargo check` to download dependencies and ensure there are no compilation issues. +1. Build the buildpack: + +``` +cargo libcnb package +``` + +### Generate an application image + +Once you have have built the buildpack you can use `pack build` to generate an application image. + +``` +pack build sample-app \ + --buildpack packaged/x86_64-unknown-linux-musl/debug/heroku_ruby \ + --path buildpacks/ruby/tests/fixtures/default_ruby +``` + +This will create an image named `sample-app` based off of the fixture at `buildpacks/ruby/tests/fixtures/default_ruby`. + +The deployed buildpack ships with a builder that tells the `pack` CLI what other builpacks it needs. In development you must specify them via the `--buildpack` flag before this buildpack. For example to build an app that needs nodejs can run like this: + +``` +pack build sample-app \ + --buildpack heroku/nodejs-engine \ + --buildpack heroku/procfile \ + --buildpack packaged/x86_64-unknown-linux-musl/debug/heroku_ruby \ + --path +``` + +List of buildpacks this buildpack depends on: + +``` +--buildpack heroku/nodejs-engine +--buildpack heroku/nodejs-yarn +--buildpack heroku/jvm +``` + +### Run an application image + +Once an image is built you can run and inspect it. Here are some example commands. + +- Interactive execution + +``` +docker run -it --rm my-image-name bash +``` + +- Run a command and exit + +``` +docker run -it --rm my-image 'which bundle' +``` + +- Boot the default webserver + +``` +docker run -it --rm --env PORT=9292 -p 9292:9292 my-image +``` + +- Inspect the image: + +``` +pack inspect my-image +``` + +Depending on the development situation you may need to manually instruct docker to use the CNB entrypoint. You can do that by passing `--entrypoint='/cnb/lifecycle/launcher` to your docker command. + +Here is a command for building and running an image in one step with a clean cache: + +``` +export IMAGE_NAME=ruby-buildpack-example && +cargo libcnb package && +docker rmi "$IMAGE_NAME" --force && +pack build "$IMAGE_NAME" \ + --buildpack packaged/x86_64-unknown-linux-musl/debug/heroku_ruby \ + --path buildpacks/ruby/tests/fixtures/default_ruby \ + --verbose && +docker run -it --rm --entrypoint='/cnb/lifecycle/launcher' "$IMAGE_NAME" 'which bundle' +``` + +### Testing + +- `cargo test` performs Rust unit tests. +- `cargo test -- --ignored` performs all integration tests. + +See the [CI configuration](.github/workflows/ci.yml) for detailed lint and test commands. + +## Code of Conduct + +Please follow our [Code of Conduct](CODE_OF_CONDUCT.md). + +## License + +By contributing your code, you agree to license your contribution under the terms of our project [LICENSE](LICENSE) and to sign the [Salesforce CLA](https://cla.salesforce.com/sign-cla). + + +[discussions]: https://github.com/heroku/buildpacks/discussions +[issues]: https://github.com/heroku/buildpacks-ruby/issues +[libcnb]: https://github.com/heroku/libcnb.rs +[libcnb-deps]: https://github.com/heroku/libcnb.rs#development-environment-setup +[pulls]: https://github.com/heroku/buildpacks-ruby/pulls +[roadmap]: https://github.com/heroku/roadmap diff --git a/README.md b/README.md index 5d54ad6b..28cce646 100644 --- a/README.md +++ b/README.md @@ -1,259 +1,92 @@ -# Heroku Ruby cloud native buildpack (CNB) +# Heroku Cloud Native Buildpacks: Ruby -[![CI](https://github.com/heroku/buildpacks-ruby/actions/workflows/ci.yml/badge.svg)](https://github.com/heroku/buildpacks-ruby/actions/workflows/ci.yml) +[![Cloud Native Buildpacks Registry: heroku/ruby][registry-badge]](https://registry.buildpacks.io/buildpacks/heroku/ruby) +[![CI on GitHub Actions: heroku/ruby](https://github.com/heroku/buildpacks-ruby/actions/workflows/ci.yml/badge.svg)](https://github.com/heroku/buildpacks-ruby/actions/workflows/ci.yml) -Heroku's official [Cloud Native Buildpacks](https://buildpacks.io/) for the Ruby ecosystem. +![Heroku Cloud Native Buildpack: heroku/ruby](https://cloud.githubusercontent.com/assets/51578/13712725/3c6b3368-e793-11e5-83c1-728440111358.png) -## Classic Heroku Buildpack +Build your Ruby and Rails application source code into an [OCI images](https://opencontainers.org/) with minimal configuration using the project, no `Dockerfile` required. To learn more about what a CNB is, how they work, and how to use one to build your application, see the [Heroku CNB documentation][heroku-buildpacks]. -If you're looking for the repositories of the classic Ruby Heroku buildpack for usage on the Heroku platform, please see [heroku/ruby](https://github.com/heroku/heroku-buildpack-ruby). +> [!IMPORTANT] +> This is a collection of [Cloud Native Buildpacks][cnb], and is a component of the [Heroku Cloud Native Buildpacks][heroku-buildpacks] project, which is in beta. If you are instead looking for the Heroku Classic Buildpack for Ruby (for use on the Heroku platform), you may find it [here][classic-buildpack]. To read about differences between the buildpacks see [docs/upgrading.md](docs/upgrading.md). -If you're migrating from the classic buildpack, known differences are documented below. +## Usage -## What is a buildpack? +> [!NOTE] +> Before getting started, ensure you have the [`pack` CLI installed][pack-install]. -Buildpacks take in an application's code and prepare it to run, usually in production. Unlike a declarative system like Dockerfile, buildpacks are designed to be low or no configuration required. They can inspect the application and make dynamic adjustments using common community standards. +To build a Ruby application codebase into a production image: -This buildpack is a Cloud Native Buildpack (CNB). CNB is a specification for building [OCI images](https://opencontainers.org/) (like docker). Some services natively support CNBs while other services might require you to generate an image locally and deploy that image through a container registry service. - -You can find out more about the CNB project at https://buildpacks.io/. - -## Use `heroku/ruby` CNB locally with `pack` - -To use the currently deployed `heroku/ruby` buildpack locally, you'll need a copy of `pack` installed. On a mac you can run: - -``` -$ brew install pack +```bash +$ cd ~/workdir/sample-ruby-app +$ pack build sample-app --builder heroku/builder:22 ``` -You'll also need to run [docker desktop](https://www.docker.com/products/docker-desktop/). With docker running, run the buildpack against a Ruby application by running: +> [!NOTE] +> You can skip needing to pass the `--builder` flag by setting a default builder with `pack config default-builder heroku/builder:22`. -``` -$ pack build --builder heroku/builder:22 --path -``` +Then run the image: -For example: - -``` -$ cd /tmp -$ git clone https://github.com/heroku/ruby-getting-started -$ cd ruby-getting-started -$ pack build my-image --builder heroku/builder:22 --path ./ruby-getting-started -===> ANALYZING -Previous image with name "my-image" not found -===> DETECTING -# ... +```bash +docker run --rm -it -e "PORT=9292" -p 9292:9292 sample-app ``` -The buildpack is released to Heroku's [heroku/builder images](https://github.com/heroku/cnb-builder-images). This buildpack is currently released on: - -- `heroku/builder:22` - -## Application contract - -The sections below describe the expected behavior of the buildpack. The codebase must be updated if a difference exists between this contract and actual behavior. Either the code needs to change to suit the contract, or the contract needs to be updated. If you see a difference, please open an issue with a [minimal application that reproduces the problem](https://www.codetriage.com/example_app). - -If you need application-specific support, you can ask on an official Heroku support channel or Stack Overflow. - -### Application Contract: Detect - -The detect phase determines whether or not this buildpack can execute. It can also be used to request additional functionality via requiring behavior from other buildpacks. - -- Node version - - Given a `package.json` file in the root of the application the `heroku/nodejs-engine` buildpack will be required. [See README for behavior](https://github.com/heroku/buildpacks-nodejs/tree/main/buildpacks/nodejs-engine) -- Yarn version - - Given a `yarn.lock` file in the root of the application the `heroku/nodejs-yarn` buildpack will be required. [See README for behavior](https://github.com/heroku/buildpacks-nodejs/tree/main/buildpacks/nodejs-yarn) -- Java version - - Given a `Gemfile.lock` file that specifies jruby the `heroku/jvm` buildpack will be required. [See README for behavior](https://github.com/heroku/buildpacks-jvm/) -- Ruby version - - Given a `Gemfile.lock` this buildpack will execute the Ruby build contract below. - -### Application Contract: Build - -Once an application has passed the detect phase, the build phase will execute to prepare the application to run. - -- Ruby version: - - Given a `Gemfile.lock` with an explicit Ruby version, we will install that Ruby version. - - Given a `Gemfile.lock` without an explicit Ruby version, we will install a default Ruby version. - - When the default value changes, applications without an explicit Ruby version will receive the updated version on their next deployment. - - We will reinstall Ruby if your stack (operating system) changes. -- Bundler version: - - Given a `Gemfile.lock` with an explicit Bundler version we will install that bundler version. - - Given a `Gemfile.lock` without an explicit Bundler version we will install a default Ruby version. -- Ruby Dependencies: - - We MAY install gem dependencies using `bundle install` - - We will always run `bundle install` for the first build. - - We will sometimes run this command again if we detect one of the following has changed: - - `Gemfile` - - `Gemfile.lock` - - User configurable environment variables. - -To always run `bundle install` even if there are changes if the environment variable `HEROKU_SKIP_BUNDLE_DIGEST=1` is found. - - We will always run `bundle clean` after a successful `bundle install` via setting `BUNDLE_CLEAN=1` environment variable. - - We will always cache the contents of your gem dependencies. - - We will always invalidate the dependency cache if your stack (operating system) changes. - - We will always invalidate the dependency cache if your Ruby version changes. - - We may invalidate the dependency cache if there was a bug in a prior buildpack version that needs to be fixed. -- Gem specific behavior - We will parse your `Gemfile.lock` to determine what dependencies your app need for use in specializing your install behavior (i.e. Rails 5 versus Rails 4). The inclusion of these gems may trigger different behavior: - - `railties` -- Applications without `rake` in the `Gemfile.lock` or a `Rakefile` variant MAY skip rake task detection. -- Rake execution - We will determine what rake tasks are runnable via the output of `rake -P` against your application. - - We will always abort the build if the `rake -p` task fails. - - We will always run `rake assets:precompile` on your app if that task exists for your application. - - We will always skip this `assets:precompile` task if a manifest file exists in the `public/assets` folder that indicates precompiled assets are checked into git. - - `.sprockets-manifest-*.json` - - `manifest-*.json` - - We will abort your build if the `rake assets:precompile` task fails. - - We will run `rake assets:clean` on your app. - - We will cache the contents of `public/assets` if `assets:clean` exists on your application. - - We will cache asset "fragments" directories if the `assets:clean` exists on the system. - - We will limit or prune the size of the asset cache in `tmp/cache/assets` to 100 MiB. - - We will delete the least recently used (LRU) files first. Detected via file mtime. -- Process types: - - Given an application with the `railties` gem: - - We will default the web process to `bin/rails server` while specifying `-p $PORT` and `-e $RAILS_ENV"`. Use the `Procfile` to override this default. - - If `railties` gem is not found but `rack` gem is present and a `config.ru` file exists on root: - - We will default the web process to `rackup` while specifying `-p $PORT` and `-h 0.0.0.0`. Use the `Procfile` to override this default. . -- Environment variable defaults - We will set a default for the following environment variables: - - `JRUBY_OPTS="-Xcompile.invokedynamic=false"` - Invoke dynamic is a feature of the JVM intended to enhance support for dynamicaly typed languages (such as Ruby). This caused issues with Physion Passenger 4.0.16 and was disabled [details](https://github.com/heroku/heroku-buildpack-ruby/issues/145). You can override this value. - - `RACK_ENV=${RACK_ENV:-"production"}` - An environment variable that may affect the behavior of Rack based webservers and webapps. You can override this value. - - `RAILS_ENV=${RAILS_ENV:-"production"}` - A value used by all Rails apps. By default, Rails ships with three environments: `development`, `test,` and `production`. We recommend all apps being deployed to use `production` and recommend against using a custom env such as `staging` [details](https://devcenter.heroku.com/articles/deploying-to-a-custom-rails-environment). You can override this value. - - `SECRET_KEY_BASE=${SECRET_KEY_BASE:-}` - In Rails 4.1+ apps a value is needed to generate cryptographic tokens used for a variety of things. Notably this value is used in generating user sessions so modifying it between builds will have the effect of logging out all users. This buildpack provides a default generated value. You can override this value. - - `BUNDLE_WITHOUT=development:test` - Tells bundler to not install `development` or `test` groups during `bundle install`. You can override this value. -- Environment variables modified - In addition to the default list this is a list of environment variables that the buildpack modifies: - - `BUNDLE_BIN=/bin` - Install executables for all gems into specified path. - - `BUNDLE_CLEAN=1` - After successful `bundle install` bundler will automatically run `bundle clean` to remove all stale gems from previous builds that are no longer specified in the `Gemfile.lock`. - - `BUNDLE_DEPLOYMENT=1` - Requires `Gemfile.lock` to be in sync with the current `Gemfile`. - - `BUNDLE_GEMFILE=/Gemfile` - Tells bundler where to find the `Gemfile`. - - `BUNDLE_PATH=` - Directs bundler to install gems to this path - - `DISABLE_SPRING="1"` - Spring is a library that attempts to cache application state by forking and manipulating processes with the goal of decreasing development boot time. Disabling it in production removes significant problems [details](https://devcenter.heroku.com/changelog-items/1826). - - `GEM_PATH=` - Tells Ruby where gems are located. - - `MALLOC_ARENA_MAX=2` - Controls glibc memory allocation behavior with the goal of decreasing overall memory allocated by Ruby [details](https://devcenter.heroku.com/changelog-items/1683). - - `PATH` - Various executables are installed and the `PATH` env var will be modified so they can be executed at the system level. This is mostly done via interfaces provided by `libcnb` and CNB layers rather than directly. - - `RAILS_LOG_TO_STDOUT="enabled"` - Sets the default logging target to STDOUT for Rails 5+ apps. [details](https://blog.heroku.com/container_ready_rails_5) - - `RAILS_SERVE_STATIC_FILES="enabled"` - Enables the `ActionDispatch::Static` middleware for Rails 5+ apps so that static files such as those in `public/assets` are served by the Ruby webserver such as Puma [details](https://blog.heroku.com/container_ready_rails_5). - -### Next-gen application contract - -These are tracked things the buildpack will eventually do in the application contract but are not currently implemented. - -- [TODO] Warn on invalid Ruby binstub (https://github.com/heroku/heroku-buildpack-ruby/blob/main/lib/language_pack/helpers/binstub_wrapper.rb, and https://github.com/heroku/heroku-buildpack-ruby/blob/main/lib/language_pack/helpers/binstub_check.rb) -- [TODO] Warn on default ruby version (https://github.com/heroku/heroku-buildpack-ruby/blob/26065614274ed1138620806c9a8d705e39b4412c/lib/language_pack/ruby.rb#L532) -- [TODO] Warn on Ruby version not in Gemfile.lock, but present in `bundle platform --ruby` -- [TODO] Warn on outdated ruby version (https://github.com/heroku/heroku-buildpack-ruby/blob/main/lib/language_pack/helpers/outdated_ruby_version.rb) -- [TODO] Run `rails runner` to collect configuration, abort a build if it fails (https://github.com/heroku/heroku-buildpack-ruby/blob/main/lib/language_pack/helpers/rails_runner.rb) -- [TODO] Warn when `RAILS_ENV=staging` (https://github.com/heroku/heroku-buildpack-ruby/blob/2b567c597d5cb110774eb21b9616b311d8e4ee9d/lib/language_pack/rails2.rb#L65-L71) -- [TODO] Warn if we cannot run a Web process - - [TODO] Warn no Procfile (https://github.com/heroku/heroku-buildpack-ruby/blob/26065614274ed1138620806c9a8d705e39b4412c/lib/language_pack/base.rb#L156-L158) - - [TODO] Warn Railties, but no `bin/rails` binstub (new) - - [TODO] Warn no Procfile, no Railties, and missing: `rack` gem or `config.ru` file. (new) -- [TODO-never-fail-rake] Make a buildpack that moves the contents of the Rakefile into another file like `heroku_buildpack_wrapped_rakefile.rb` and then replaces Rake with: +For detailed usage documentation see [Heroku Cloud Native Buildpacks][heroku-buildpacks]. -``` -begin - require_relative "heroku_buildpack_wrapped_rakefile.rb" -rescue => e - STDERR.puts <<~EOM - Error caught and ignored while loading Rakefile - - To fail the build instead, remove the buildpack TODO - - Message: - #{e.message} - EOM -end -``` - -### Known differences against `heroku/heroku-buildpack-ruby` - -This buildpack does not port all behaviors of the [original buildpack for Ruby ](https://github.com/heroku/heroku-buildpack-ruby), which is also known as "classic". This section outlines the known behaviors where the two buildpacks diverge. +## Application Requirements -- Rails 5+ support only. The classic buildpack supports Rails 2+. There are significant maintenance gains for buildpack authors [starting in Rails 5](https://blog.heroku.com/container_ready_rails_5) which was released in 2016. In an effort to reduce overall internal complexity this buildpack does not explicitly support Rails before version 5. -- Rails support is now based on the above application contract. Previously there was no official policy for dropping support for older Rails versions. Support was based on whether or not an older version could run on a currently supported Ruby version. With [Rails LTS](https://railslts.com/) this can mean a very old version of Rails. Now we will actively support Rails versions currently [under the Rails core maintenance policy](https://guides.rubyonrails.org/maintenance_policy.html) provided those versions can run on a supported Ruby version. As Rails versions go out of official maintenance compatibility features may be removed with no supported replacement. -- Ruby versions come from the `Gemfile.lock` only. Before bundler started recording the Ruby version in the `Gemfile.lock`, Heroku would pull the Ruby version via running `bundle platform --ruby` to pull any ruby declaration such as `ruby "3.1.2"` from the `Gemfile`. This creates a bootstrapping problem, because you need a version of Ruby to run `bundle platform` to find the version of Ruby the application needs. Since the Ruby version is now recorded in the `Gemfile.lock`, this extra bootstrapping problem is less needed and applications should rely on their version being in their `Gemfile.lock` instead. To update the Ruby version in `Gemfile.lock` run `bundle update --ruby`. -- Default Ruby versions are no longer sticky. Before bundler started recording the Ruby version in the `Gemfile.lock` it was common for developers to forget to declare their Ruby version in their project. When that happens they would receive the default Ruby version from the classic buildpack. To guard against instability the classic buildpack would record that version and use it again on all future deploys where no explicit version was specified. Now it's less likely for an app to deploy without a ruby version in their `Gemfile.lock`, and we do not want to encourage relying on a default for stability (as this otherwise breaks dev-prod parity). -- Failure to detect rake tasks will fail a deployment. On all builds `rake -p` is called to find a list of all rake tasks. If this detection task fails then the previous behavior was to fail the build only if the `sprockets` gem was present. The reason was to allow API-only apps that don't need to generate assets to have a `Rakefile` that cannot be run in production (the most common reason is they're requiring a library not in their production gemfile group). Now all failures when loading a `Rakefile` will fail the build. If you want the old behavior you can [TODO](TODO-never-fail-rake). The reason for this change is that it's more common that applications will want their builds to fail even if they're not using `sprockets`. It's also just not a good idea to not have your `Rakefile` not runable in production, we shouldn't encourage that pattern. -- Caching of `public/assets` is gated on the presence of `rake assets:clean`. Previously this behavior was gated on the existence of a certain version of the Rails framework. -- Caching of `tmp/cache/assets` (fragments) is gated on the presence of `rake assets:clean`. Previously this behavior was gated on the existence of a certain version of the Rails framework. +The `heroku/ruby` buildpack requires applications have a valid `Gemfile` and `Gemfile.lock` in the root of their project. -## Development +For more details you can view the [Ruby buildpack's specification](docs/application_contract.md) which goes into detail on buildpack behavior and enumerates the expected contract between your application and the buildpack. -### Setup the project +## Configuration -- Follow setup instructions on https://github.com/Malax/libcnb.rs +### Ruby version -### Compile the buildpack +To select a Ruby version, specify it in your `Gemfile` like this: -To build a debug release (faster to compile) run: - -``` -$(set -pipefail; cd buildpacks/ruby && cargo libcnb package; cd -) +```ruby +ruby "3.3.0" ``` -To build a production release (faster to run, slower to compile) run this command: +And ensure it is in your `Gemfile.lock` by running: ``` -$(set -pipefail; cd buildpacks/ruby && cargo libcnb package --release; cd -) +$ bundle update --ruby ``` -### Use that compiled buildpack on an application - -To build the application vendored in `buildpacks/ruby/tests/fixtures/default_ruby` you can run: +You should see a section in the `Gemfile.lock` that corresponds to your Ruby version: ``` -pack build my-image --buildpack packaged/x86_64-unknown-linux-musl/debug/heroku_ruby --path buildpacks/ruby/tests/fixtures/default_ruby --verbose +RUBY VERSION + ruby 3.3.0p0 ``` -The deployed buildpack ships with a builder that tells the `pack` CLI what other builpacks it needs. In development you must specify them via the `--buildpack` flag before this buildpack. For example to build an app that needs nodejs can run like this: +If no Ruby version is found in the `Gemfile.lock` a default version of Ruby will be provided. We highly suggest specifying a version to prevent surprise changes. -``` -pack build my-image --buildpack heroku/nodejs-engine --buildpack heroku/procfile --buildpack packaged/x86_64-unknown-linux-musl/debug/heroku_ruby --path --verbose -``` - -List of buildpacks this buildpack depends on: - -``` ---buildpack heroku/nodejs-engine ---buildpack heroku/nodejs-yarn ---buildpack heroku/jvm -``` - -### Run the image +### Bundler version -Run a command and exit: +To select a Bundler version, ensure your `Gemfile.lock` contains a locked value. For example: ``` -$ docker run -it --rm --entrypoint='/cnb/lifecycle/launcher' my-image 'which ruby' -/layers/heroku_ruby/ruby/bin -$ docker run -it --rm --entrypoint='/cnb/lifecycle/launcher' my-image 'ruby -v' -ruby 2.7.4p191 (2021-07-07 revision a21a3b7d23) [x86_64-linux] +BUNDLED WITH + 2.5.6 ``` -Make sure it doesn't say `/usr/bin/ruby` or another system ruby location - -As a oneliner: - -``` -cargo libcnb package && -docker rmi my-image --force && -pack build my-image --buildpack packaged/x86_64-unknown-linux-musl/debug/heroku_ruby --path buildpacks/ruby/tests/fixtures/default_ruby --verbose && -docker run -it --rm --entrypoint='/cnb/lifecycle/launcher' my-image 'which bundle' -``` +If no Bundler version is found in the `Gemfile.lock` a default version of Bundler will be provided. We highly suggest specifying a version to prevent surprise changes. -Run it interactively: +For more details you can view the [Ruby buildpack's specification](docs/application_contract.md) which goes into detail on buildpack behavior and enumerates the expected contract between your application and the buildpack. -``` -docker run -it --rm --entrypoint='/cnb/lifecycle/launcher' my-image bash -``` +## Included Buildpacks -Run the webserver: +The `heroku/ruby` buildpack is a standalone buildpack. This is in contrast to some other buildpacks that are composed of several smaller buildpacks such as [heroku/nodejs](https://github.com/heroku/buildpacks-nodejs?tab=readme-ov-file#included-buildpacks). -``` -docker run -it --rm --env PORT=9292 -p 9292:9292 my-image -``` +## Contributing +Issues and pull requests are welcome. See our [contributing guidelines](CONTRIBUTING.md) if you would like to help. -Inspect the image: -``` -pack inspect my-image -``` +[pack-install]: https://buildpacks.io/docs/for-platform-operators/how-to/integrate-ci/pack/ +[classic-buildpack]: https://github.com/heroku/heroku-buildpack-ruby +[heroku-buildpacks]: https://github.com/heroku/buildpacks +[registry-badge]: https://img.shields.io/badge/dynamic/json?url=https://registry.buildpacks.io/api/v1/buildpacks/heroku/ruby&label=version&query=$.latest.version&color=DF0A6B&logo=data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAADAAAAAwCAYAAABXAvmHAAAAAXNSR0IArs4c6QAACSVJREFUaAXtWQ1sFMcVnp/9ub3zHT7AOEkNOMYYp4CQQFBLpY1TN05DidI2NSTF0CBFQAOBNrTlp0a14sipSBxIG6UYHKCO2ka4SXD4SUuaCqmoJJFMCapBtcGYGqMkDgQ4++52Z2e3b87es+/s+wNHVSUPsnZv9s2b97335v0MCI2NMQ2MaeD/WgP4FqQnX//2K4tVWfa0X+9+q/N4dfgWeESXPPjUUd+cu+5cYmMcPvzawQOtrdVG9GMaLxkD+OZDex6WVeUgwhiZnH1g62bNX4+sPpLGXvEkdPNzLd93e9y/cCnabIQJCnz+2Q9rNs9tjCdM9ltK9nGkb5jYxYjIyDJDSCLSV0yFHCr/XsObvQH92X+8u/b0SGvi5zZUn1joc/u2qapajglB4XAfUlQPoqpyRzxtqt8ZA+AIcQnZEb6WZSKCMSZUfSTLg8vv/86e3b03AztO/u3p7pE2fvInfy70TpiwRVKU5YqqygbTEWL9lISaiDFujbQu2VzGAIYzs5HFDUQo8WKibMzy0Yr7Ht5Td/Nyd0NLS3VQ0FesOjDurtwvPaWp6gZVc080TR2FQn0xrAgxkWVkLD8aBQD9cti2hWwAQimdImHpJTplcmXppF11hcV3Z/n92RsVVbuHc4bCod4YwZ0fHACYCCyS4Rg1AM6+ts2R+JOpNF/Okl/PyvLCeQc/j9O4Q+88hQWY/j+0gCOI84ycD0oRNxnSAVCqgYUFgDbTMeoWiBeAcRNRm8ZPD/uNCYfIZg6bTzXxxQKw4YCboH3SH7WSCRNxIQCb6fhiAYA0JgAgaQAQFhC0mY6MAYAzUIj9KN3jZoJbUEhWqQYBAJxZqX0tjlHGACyLtzKmM0pl2YKwmHzYcIjBt0kyuBhJVEKGHkKQ2DqT8xv+NWPEF9uOtOVNLz8B6XcqJVI+JGIIm4l8HCNVVSLfbctG8X9wOBDCFOl6+FRI19c07TvQjNDZRMyGSw8zGRdzUS7zVsnfyJtfSTHZLMlKkQ1lhUhmQ4cAl5XlgTwQu43IC4TK4PN6t8nMHR093bvOHPtZbGoeyijJeyznJISJPhWVvjAxL9u/VsZoHZGUif1u1a9EIbjLpQ4CgN/gegiE7uW2uffzgFV34tCK/yTinc78bQNwNllY9nKRy+feBE6xnEpS9HwoihwBQIgEGgdfs81mHjaeeeftJ/7prL2d56gBcIQoXfzbUpXKVUSWy8QcgQgkPMi0+IeQnZ899sYThxza0XiOOoABoQhUpJUypusRBFyO0W/ea/vLH1FrU0bd1mgAvD0ecNDRzGrl9pgkXB1RvlQw5dEyrKpVEI8+Ni19+6Xzr9+yby57sNrnK5y12u3xPhIOB8+d7mhbv//tTQaetmanROX5JueNXfzs7+7rPH7LffS1Rw9+zZvt34glktv3yaev4IIZK25CZPCKiAqVYx+yccONa589f/Xq4RG7qgT6ICtXv7ZU83i2ujXvLAQdmwiVXZyX/Lppn8Fo7ilnnW6xDwjnz+R31B915tJ53lj8++mu3JytxKVUSrIGCdiC8juMcNE9KyHmObkDkhKUwJZhdnHbqOvsC+xBVw5FuqpEmyxZtv+rvmzXNk3THsCQlETTIgaB7NojKSU7m/Zik+SeNAZyhCJobMjnNv8TENcWXKz/KBFvMX9uQe2EKQUz18kedb3syhrPuI6sgcQpwjQAeNyRPsrHBu1FLMLNFspYbXvHH96Mfhx4WbSorsh/5/hNbpdnmaIoqmnGnk8RNq/IVkl9czNi2P8+G5LkhPOq8J1Z7Aa37YZAyNg5p7vh8tA96tE8ecl3f7pc9bi3aJq3EGiRCTxwnLQjAnAY9QMRJbHdrKO+2sttTR/OXrjZ/+Wpdz8JGt+gaFqOaFjiM7BY3w/ALtl79OgwAA5/URSqYJGwbV6yLf58e+DC/gc+OdZ3/VsNZdTr3+bSXPfCfRFiSWqupACcjWxhdmYGFU19b9bsudO9Xl9xpHSwYksHh148oVYCC9gljcfeTQjAoZfA4hQEDXGjxZcz41PP5Mn3K5Is6dBjxyncWRJ9plWNYmgJIR+5PZrnIZeqpuxvBXcCFWiqWtWRQriGCZKCW81zQw8N1kDBkBFJgA5NomdaACKLoSnh0DGJsjdx9Tm4DQELhKAXEBukC0Sck7ARRrKhAgi45Rhkl/AtfQAWRCj4x5jw+dSssbAAzrzDEn0xNyAgpLGHQJU+ACC2QCsscmhTAxAuhFDm+cpm4oIrIwAiqKUWCIgghIEFBABoTlINASCE4arEphCsU1EPfhcWIGDlVBYQEgi2ElSJBqWSgofE6UF2sW8WCM5AOwJI8gE9M9g2GGTIJUnMsgkAEQ6Yah3IDQAsIzUAEbmEGJJlsqW2jZ+DEr4Y7m2TCicEMFOcAXF4xRkx9eAbNy+fORcIZzHDJb8KGz4Ot9lUhwiTbEQAJLEAFOeQOyQUNINdjIWrIsbNy6sYr2quH0HS+DFVlImYi01itSW0D/8vgLLHjR/2TQgkah8Ra8HFTjGOa06f3A797SCTCwWry8DSVXBvWhoJBgksLlM/3N6rw1xICOoCwXXOAlAU1tvBqzumdL18JcY7cwp+MH2cJG8CaVZgqPBE/HeG2FSWZCTi9NAhHFxkXYOzbpvznd2dZ3b19Bwf8Qb3AJqpLCgsrYRC6ecqJjMM4A+lxFB2SCbiLlWGucF5RXRzFgNK6yAzwzX551+MVswxABxOefmP3etS5a2YSuVizjkfBAo9l0tzyCDbSqKC7YUIu/daOFB3pbUxrf721B0rc/w+9zrYfK2K5QlhcCvnfFCigUr6L0ucDA3KeR8iYO3U8y8M6+ZGBDAgIc0vWl5BEakiijQTYmhkWpEVEBwOELgUt+y3QtysuXT21ahGoujSePl3/qpiRVK2wO3KY1ClyuJ8YHATcDPIyhQFud6JbfKr1vZz+xehd0a8e08GICKC318xzpejrpUQ3UAkaZK4yoGU/HduWts72hsPpyFnSpL2wjWlFNFfSoSWipqIWVYP1J27rwcCL839eF9PMgYpATiLJ01eOs2jaU+D03508cK/9iHUkm6F4LBI+hTlc9m0BSsVSufcCBkvzu7afSHpgrGPYxoY00BEA/8FOPrYBqYsE44AAAAASUVORK5CYII=&labelColor=white diff --git a/docs/application_contract.md b/docs/application_contract.md new file mode 100644 index 00000000..08b22fc5 --- /dev/null +++ b/docs/application_contract.md @@ -0,0 +1,82 @@ +## Application contract + +The sections below describe the expected behavior of the buildpack. The codebase must be updated if a difference exists between this contract and actual behavior. Either the code needs to change to suit the contract, or the contract needs to be updated. If you see a difference, please open an issue with a [minimal application that reproduces the problem](https://www.codetriage.com/example_app). + +If you need application-specific support, you can ask on an official Heroku support channel or Stack Overflow. + +### Application Contract: Detect + +The detect phase determines whether or not this buildpack can execute. It can also be used to request additional functionality via requiring behavior from other buildpacks. + +- Node version + - Given a `package.json` file in the root of the application the `heroku/nodejs-engine` buildpack will be required. [See README for behavior](https://github.com/heroku/buildpacks-nodejs/tree/main/buildpacks/nodejs-engine) +- Yarn version + - Given a `yarn.lock` file in the root of the application the `heroku/nodejs-yarn` buildpack will be required. [See README for behavior](https://github.com/heroku/buildpacks-nodejs/tree/main/buildpacks/nodejs-yarn) +- Java version + - Given a `Gemfile.lock` file that specifies jruby the `heroku/jvm` buildpack will be required. [See README for behavior](https://github.com/heroku/buildpacks-jvm/) +- Ruby version + - Given a `Gemfile.lock` this buildpack will execute the Ruby build contract below. + +### Application Contract: Build + +Once an application has passed the detect phase, the build phase will execute to prepare the application to run. + +- Ruby version: + - Given a `Gemfile.lock` with an explicit Ruby version, we will install that Ruby version. + - Given a `Gemfile.lock` without an explicit Ruby version, we will install a default Ruby version. + - When the default value changes, applications without an explicit Ruby version will receive the updated version on their next deployment. + - We will reinstall Ruby if your stack (operating system) changes. +- Bundler version: + - Given a `Gemfile.lock` with an explicit Bundler version we will install that bundler version. + - Given a `Gemfile.lock` without an explicit Bundler version we will install a default Ruby version. +- Ruby Dependencies: + - We MAY install gem dependencies using `bundle install` + - We will always run `bundle install` for the first build. + - We will sometimes run this command again if we detect one of the following has changed: + - `Gemfile` + - `Gemfile.lock` + - User configurable environment variables. + -To always run `bundle install` even if there are changes if the environment variable `HEROKU_SKIP_BUNDLE_DIGEST=1` is found. + - We will always run `bundle clean` after a successful `bundle install` via setting `BUNDLE_CLEAN=1` environment variable. + - We will always cache the contents of your gem dependencies. + - We will always invalidate the dependency cache if your stack (operating system) changes. + - We will always invalidate the dependency cache if your Ruby version changes. + - We may invalidate the dependency cache if there was a bug in a prior buildpack version that needs to be fixed. +- Gem specific behavior - We will parse your `Gemfile.lock` to determine what dependencies your app need for use in specializing your install behavior (i.e. Rails 5 versus Rails 4). The inclusion of these gems may trigger different behavior: + - `railties` +- Applications without `rake` in the `Gemfile.lock` or a `Rakefile` variant MAY skip rake task detection. +- Rake execution - We will determine what rake tasks are runnable via the output of `rake -P` against your application. + - We will always abort the build if the `rake -p` task fails. + - We will always run `rake assets:precompile` on your app if that task exists for your application. + - We will always skip this `assets:precompile` task if a manifest file exists in the `public/assets` folder that indicates precompiled assets are checked into git. + - `.sprockets-manifest-*.json` + - `manifest-*.json` + - We will abort your build if the `rake assets:precompile` task fails. + - We will run `rake assets:clean` on your app. + - We will cache the contents of `public/assets` if `assets:clean` exists on your application. + - We will cache asset "fragments" directories if the `assets:clean` exists on the system. + - We will limit or prune the size of the asset cache in `tmp/cache/assets` to 100 MiB. + - We will delete the least recently used (LRU) files first. Detected via file mtime. +- Process types: + - Given an application with the `railties` gem: + - We will default the web process to `bin/rails server` while specifying `-p $PORT` and `-e $RAILS_ENV"`. Use the `Procfile` to override this default. + - If `railties` gem is not found but `rack` gem is present and a `config.ru` file exists on root: + - We will default the web process to `rackup` while specifying `-p $PORT` and `-h 0.0.0.0`. Use the `Procfile` to override this default. . +- Environment variable defaults - We will set a default for the following environment variables: + - `JRUBY_OPTS="-Xcompile.invokedynamic=false"` - Invoke dynamic is a feature of the JVM intended to enhance support for dynamicaly typed languages (such as Ruby). This caused issues with Physion Passenger 4.0.16 and was disabled [details](https://github.com/heroku/heroku-buildpack-ruby/issues/145). You can override this value. + - `RACK_ENV=${RACK_ENV:-"production"}` - An environment variable that may affect the behavior of Rack based webservers and webapps. You can override this value. + - `RAILS_ENV=${RAILS_ENV:-"production"}` - A value used by all Rails apps. By default, Rails ships with three environments: `development`, `test,` and `production`. We recommend all apps being deployed to use `production` and recommend against using a custom env such as `staging` [details](https://devcenter.heroku.com/articles/deploying-to-a-custom-rails-environment). You can override this value. + - `SECRET_KEY_BASE=${SECRET_KEY_BASE:-}` - In Rails 4.1+ apps a value is needed to generate cryptographic tokens used for a variety of things. Notably this value is used in generating user sessions so modifying it between builds will have the effect of logging out all users. This buildpack provides a default generated value. You can override this value. + - `BUNDLE_WITHOUT=development:test` - Tells bundler to not install `development` or `test` groups during `bundle install`. You can override this value. +- Environment variables modified - In addition to the default list this is a list of environment variables that the buildpack modifies: + - `BUNDLE_BIN=/bin` - Install executables for all gems into specified path. + - `BUNDLE_CLEAN=1` - After successful `bundle install` bundler will automatically run `bundle clean` to remove all stale gems from previous builds that are no longer specified in the `Gemfile.lock`. + - `BUNDLE_DEPLOYMENT=1` - Requires `Gemfile.lock` to be in sync with the current `Gemfile`. + - `BUNDLE_GEMFILE=/Gemfile` - Tells bundler where to find the `Gemfile`. + - `BUNDLE_PATH=` - Directs bundler to install gems to this path + - `DISABLE_SPRING="1"` - Spring is a library that attempts to cache application state by forking and manipulating processes with the goal of decreasing development boot time. Disabling it in production removes significant problems [details](https://devcenter.heroku.com/changelog-items/1826). + - `GEM_PATH=` - Tells Ruby where gems are located. + - `MALLOC_ARENA_MAX=2` - Controls glibc memory allocation behavior with the goal of decreasing overall memory allocated by Ruby [details](https://devcenter.heroku.com/changelog-items/1683). + - `PATH` - Various executables are installed and the `PATH` env var will be modified so they can be executed at the system level. This is mostly done via interfaces provided by `libcnb` and CNB layers rather than directly. + - `RAILS_LOG_TO_STDOUT="enabled"` - Sets the default logging target to STDOUT for Rails 5+ apps. [details](https://blog.heroku.com/container_ready_rails_5) + - `RAILS_SERVE_STATIC_FILES="enabled"` - Enables the `ActionDispatch::Static` middleware for Rails 5+ apps so that static files such as those in `public/assets` are served by the Ruby webserver such as Puma [details](https://blog.heroku.com/container_ready_rails_5). diff --git a/docs/upgrading.md b/docs/upgrading.md new file mode 100644 index 00000000..d3aa70d3 --- /dev/null +++ b/docs/upgrading.md @@ -0,0 +1,14 @@ + +## Upgrading from the classic Ruby buildpack + +This buildpack does not port all behaviors of the [classic buildpack for Ruby ](https://github.com/heroku/heroku-buildpack-ruby), which is also known as "classic". This section outlines the known behaviors where the two buildpacks diverge. + +## Differences + +- Rails 5+ support only. The classic buildpack supports Rails 2+. There are significant maintenance gains for buildpack authors [starting in Rails 5](https://blog.heroku.com/container_ready_rails_5) which was released in 2016. In an effort to reduce overall internal complexity this buildpack does not explicitly support Rails before version 5. +- Rails support is now based on the above application contract. Previously there was no official policy for dropping support for older Rails versions. Support was based on whether or not an older version could run on a currently supported Ruby version. With [Rails LTS](https://railslts.com/) this can mean a very old version of Rails. Now we will actively support Rails versions currently [under the Rails core maintenance policy](https://guides.rubyonrails.org/maintenance_policy.html) provided those versions can run on a supported Ruby version. As Rails versions go out of official maintenance compatibility features may be removed with no supported replacement. +- Ruby versions come from the `Gemfile.lock` only. Before bundler started recording the Ruby version in the `Gemfile.lock`, Heroku would pull the Ruby version via running `bundle platform --ruby` to pull any ruby declaration such as `ruby "3.1.2"` from the `Gemfile`. This creates a bootstrapping problem, because you need a version of Ruby to run `bundle platform` to find the version of Ruby the application needs. Since the Ruby version is now recorded in the `Gemfile.lock`, this extra bootstrapping problem is less needed and applications should rely on their version being in their `Gemfile.lock` instead. To update the Ruby version in `Gemfile.lock` run `bundle update --ruby`. +- Default Ruby versions are no longer sticky. Before bundler started recording the Ruby version in the `Gemfile.lock` it was common for developers to forget to declare their Ruby version in their project. When that happens they would receive the default Ruby version from the classic buildpack. To guard against instability the classic buildpack would record that version and use it again on all future deploys where no explicit version was specified. Now it's less likely for an app to deploy without a ruby version in their `Gemfile.lock`, and we do not want to encourage relying on a default for stability (as this otherwise breaks dev-prod parity). +- Failure to detect rake tasks will fail a deployment. On all builds `rake -p` is called to find a list of all rake tasks. If this detection task fails then the previous behavior was to fail the build only if the `sprockets` gem was present. The reason was to allow API-only apps that don't need to generate assets to have a `Rakefile` that cannot be run in production (the most common reason is they're requiring a library not in their production gemfile group). Now all failures when loading a `Rakefile` will fail the build. +- Caching of `public/assets` is gated on the presence of `rake assets:clean`. Previously this behavior was gated on the existence of a certain version of the Rails framework. +- Caching of `tmp/cache/assets` (fragments) is gated on the presence of `rake assets:clean`. Previously this behavior was gated on the existence of a certain version of the Rails framework. From f1baa65e5405accaea5b57e9b1fda7ef30faf721 Mon Sep 17 00:00:00 2001 From: Josh W Lewis Date: Fri, 8 Mar 2024 11:58:32 -0600 Subject: [PATCH 2/5] Add missing reference link --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 7ad60d85..da8dd310 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -133,7 +133,7 @@ Please follow our [Code of Conduct](CODE_OF_CONDUCT.md). By contributing your code, you agree to license your contribution under the terms of our project [LICENSE](LICENSE) and to sign the [Salesforce CLA](https://cla.salesforce.com/sign-cla). - +[cnb]: https://buildpacks.io [discussions]: https://github.com/heroku/buildpacks/discussions [issues]: https://github.com/heroku/buildpacks-ruby/issues [libcnb]: https://github.com/heroku/libcnb.rs From 6245f2508e1c1d550cd5abca08ee82b159115bdc Mon Sep 17 00:00:00 2001 From: Josh W Lewis Date: Fri, 8 Mar 2024 12:03:23 -0600 Subject: [PATCH 3/5] Apply contributing review feedback --- CONTRIBUTING.md | 21 +++------------------ 1 file changed, 3 insertions(+), 18 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index da8dd310..4b3a9d2d 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -32,9 +32,8 @@ Fixes, improvements, and patches all happen via [GitHub Pull Requests on this re This buildpack relies on [heroku/libcnb.rs][libcnb] to compile buildpacks. All [libcnb.rs dependencies][libcnb-deps] will need to be setup prior to building or testing this buildpack. -1. Install [rust by following instructions on their site](https://www.rust-lang.org/tools/install) -1. Follow the setup instructions on [heroku/libcnb](https://github.com/heroku/libcnb.rs) -1. Install the [pack cli](https://buildpacks.io/docs/for-platform-operators/how-to/integrate-ci/pack/) +1. Install [rust by following instructions on their site][install-rust] +1. Follow the setup instructions on [heroku/libcnb][libcnb-deps] ### Building the buildpack locally @@ -103,21 +102,6 @@ docker run -it --rm --env PORT=9292 -p 9292:9292 my-image pack inspect my-image ``` -Depending on the development situation you may need to manually instruct docker to use the CNB entrypoint. You can do that by passing `--entrypoint='/cnb/lifecycle/launcher` to your docker command. - -Here is a command for building and running an image in one step with a clean cache: - -``` -export IMAGE_NAME=ruby-buildpack-example && -cargo libcnb package && -docker rmi "$IMAGE_NAME" --force && -pack build "$IMAGE_NAME" \ - --buildpack packaged/x86_64-unknown-linux-musl/debug/heroku_ruby \ - --path buildpacks/ruby/tests/fixtures/default_ruby \ - --verbose && -docker run -it --rm --entrypoint='/cnb/lifecycle/launcher' "$IMAGE_NAME" 'which bundle' -``` - ### Testing - `cargo test` performs Rust unit tests. @@ -135,6 +119,7 @@ By contributing your code, you agree to license your contribution under the term [cnb]: https://buildpacks.io [discussions]: https://github.com/heroku/buildpacks/discussions +[install-rust]: https://www.rust-lang.org/tools/install [issues]: https://github.com/heroku/buildpacks-ruby/issues [libcnb]: https://github.com/heroku/libcnb.rs [libcnb-deps]: https://github.com/heroku/libcnb.rs#development-environment-setup From 5b6376d856d8f32a7b35302299a4a0287ed8330c Mon Sep 17 00:00:00 2001 From: Josh W Lewis Date: Fri, 8 Mar 2024 12:07:10 -0600 Subject: [PATCH 4/5] Move reference link to the proper file --- CONTRIBUTING.md | 1 - README.md | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 4b3a9d2d..6566a420 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -117,7 +117,6 @@ Please follow our [Code of Conduct](CODE_OF_CONDUCT.md). By contributing your code, you agree to license your contribution under the terms of our project [LICENSE](LICENSE) and to sign the [Salesforce CLA](https://cla.salesforce.com/sign-cla). -[cnb]: https://buildpacks.io [discussions]: https://github.com/heroku/buildpacks/discussions [install-rust]: https://www.rust-lang.org/tools/install [issues]: https://github.com/heroku/buildpacks-ruby/issues diff --git a/README.md b/README.md index 28cce646..0fea97d3 100644 --- a/README.md +++ b/README.md @@ -86,6 +86,7 @@ The `heroku/ruby` buildpack is a standalone buildpack. This is in contrast to so Issues and pull requests are welcome. See our [contributing guidelines](CONTRIBUTING.md) if you would like to help. +[cnb]: https://buildpacks.io [pack-install]: https://buildpacks.io/docs/for-platform-operators/how-to/integrate-ci/pack/ [classic-buildpack]: https://github.com/heroku/heroku-buildpack-ruby [heroku-buildpacks]: https://github.com/heroku/buildpacks From 2f294acaa51bdcc353dbb2a7cc2290b62d19523f Mon Sep 17 00:00:00 2001 From: Josh W Lewis Date: Fri, 8 Mar 2024 12:09:10 -0600 Subject: [PATCH 5/5] Update README.md wording --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 0fea97d3..7e0975f3 100644 --- a/README.md +++ b/README.md @@ -5,7 +5,7 @@ ![Heroku Cloud Native Buildpack: heroku/ruby](https://cloud.githubusercontent.com/assets/51578/13712725/3c6b3368-e793-11e5-83c1-728440111358.png) -Build your Ruby and Rails application source code into an [OCI images](https://opencontainers.org/) with minimal configuration using the project, no `Dockerfile` required. To learn more about what a CNB is, how they work, and how to use one to build your application, see the [Heroku CNB documentation][heroku-buildpacks]. +Build your Ruby and Rails application source code into an [OCI image](https://opencontainers.org/) with minimal configuration, no `Dockerfile` required. To learn more about what a CNB is, how they work, and how to use one to build your application, see the [Heroku CNB documentation][heroku-buildpacks]. > [!IMPORTANT] > This is a collection of [Cloud Native Buildpacks][cnb], and is a component of the [Heroku Cloud Native Buildpacks][heroku-buildpacks] project, which is in beta. If you are instead looking for the Heroku Classic Buildpack for Ruby (for use on the Heroku platform), you may find it [here][classic-buildpack]. To read about differences between the buildpacks see [docs/upgrading.md](docs/upgrading.md).