Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PATH to vendored Ruby is incorrect if buildpack dir differs from the default #107

Open
r4victor opened this issue Sep 2, 2022 · 0 comments · May be fixed by #108
Open

PATH to vendored Ruby is incorrect if buildpack dir differs from the default #107

r4victor opened this issue Sep 2, 2022 · 0 comments · May be fixed by #108

Comments

@r4victor
Copy link

r4victor commented Sep 2, 2022

After upgrading Heroku stack from 20 to 22, the nginx buildpack cannot compile nginx.conf.erb. It cannot find the erb executable.

The reason is that I use heroku-buildpack-subdir so that my runtime directory of nginx buildpack is /app/nginx. But this buildpack's compile script adds /app/.heroku-buildpack-nginx/ruby/bin to PATH, assuming that buildpack always lives in /app.

So heroku-buildpack-nginx doesn't work on Heroku stack 22 if you change the buildpack runtime directory from /app.

Now the solution could be to calculate the buildpack runtime directory from BUILD_DIR.

@r4victor r4victor linked a pull request Sep 2, 2022 that will close this issue
@r4victor r4victor changed the title PATH to vendored Ruby is incorrect if buildpack dir is not default PATH to vendored Ruby is incorrect if buildpack dir differs from the default Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant