Fail the build if multiple package manager files detected #1691
Assignees
Labels
Comments
edmorley
added a commit
that referenced
this issue
Nov 8, 2024
Currently the buildpack will use whichever package manager it finds first, if the files of multiple package managers are found. This occasionally results in support tickets where the user believes the build to not be installing dependencies correctly, when in fact they are adding dependencies to the wrong package manager file. As such, we want to make the presence of multiple package manager files an error, but first we should add a warning so it's not a surprise. (Plus with the recent Poetry support addition, there will be apps using the third party Poetry buildpack that have both a `poetry.lock` and the generated `requirements.txt` until they remove the third-party buildpack.) Towards #1691. GUS-W-17167927.
edmorley
added a commit
that referenced
this issue
Nov 8, 2024
Currently the buildpack will use whichever package manager it finds first, if the files of multiple package managers are found. This occasionally results in support tickets where the user believes the build to not be installing dependencies correctly, when in fact they are adding dependencies to the wrong package manager file. As such, we want to make the presence of multiple package manager files an error, but first we should add a warning so it's not a surprise. (Plus with the recent Poetry support addition, there will be apps using the third party Poetry buildpack that have both a `poetry.lock` and the generated `requirements.txt` until they remove the third-party buildpack.) Towards #1691. GUS-W-17167927.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently the buildpack will use whichever package manager it finds first, if the files of multiple package managers are found.
This occasionally results in support tickets where the user believes the build to not be installing dependencies correctly, when in fact they are adding dependencies to the wrong package manager file.
To avoid this, we should make the presence of multiple package manager files an error.
We'll first want to add a warning so the change is not a surprise. (Particularly with the recent Poetry support addition, there will be apps using the third party Poetry buildpack that have both a
poetry.lockand the generatedrequirements.txtuntil they remove the third-party buildpack.)GUS-W-14336556.
The text was updated successfully, but these errors were encountered: