Use heroku/builder:22 in example-basics integration test
#775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Malax
changed the title
heroku/heroku:22 in example-basics integration testheroku/heroku:22 in example-basics integration test
Malax
force-pushed
the
malax/ci-changes
branch
from
161c41d to
d2b68d3
Compare
Malax
changed the title
heroku/heroku:22 in example-basics integration testheroku/builder:22 in example-basics integration test
edmorley
approved these changes
Feb 9, 2024
edmorley
added a commit
that referenced
this pull request
Oct 25, 2024
In CI a `pack build` is performed using one of libcnb's example CNBs and the upstream `cnb/sample-builder:alpine` builder, in order to test that our static MUSL compile works with non-libc base images. However, in #594 the version of that builder had to be pinned to an older release, to work around a temporary incompatibility between the latest version of the builder and the latest stable Pack CLI: buildpacks/samples#170 In addition, in #775 the image was switched to our builder image since the example images didn't use a CNB lifecycle that was compatible with Buildpack API 0.13. Both issues have since been resolved, so we can switch back to the latest version of the upstream example alpine builder, giving us musl coverage again. GUS-W-14086879.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See code comment for details. This became a blocker for #773 since
cnbs/sample-builder@sha256:da5ff69191919f1ff30d5e28859affff8e39f23038137c7751e24a42e919c1abdoesn't contain a CNB lifecycle that is compatible with buildpack API0.10.