Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Identity requests meta does not have component #209

Open
villesau opened this issue May 29, 2018 · 1 comment · May be fixed by #210
Open

Identity requests meta does not have component #209

villesau opened this issue May 29, 2018 · 1 comment · May be fixed by #210

Comments

@villesau
Copy link

Hi,

Following definition does not get component in meta, even when withRef is true.

{
  req: {
    value: { random: 'value' },
    then: val => ({
      value: transform(val),
      andThen: (transformed, meta) => {
        // meta.component is undefined :(
        return {}
      }
    })
  }
}
@villesau
Copy link
Author

villesau commented May 29, 2018 •
edited
Loading

Fixing this would require to change the fetch to start in componentDidMount instead of componentWillMount to get the handle to the component (connect.js:199), and adding the ref to meta in case of values too (connect.js:277).

Changing the lifecycle method is reasonable but would probably require some bigger changes on how the promise state objects would be handled.

@villesau villesau linked a pull request May 30, 2018 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

WIP: Fix #209 missing component ref villesau/react-refetch
1 participant
@villesau