Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: pass *cobra.Command into ActionWaiter #655

Merged
merged 1 commit into from
Jan 2, 2024
Merged

Conversation

phm07
Copy link
Contributor

@phm07 phm07 commented Jan 2, 2024

No description provided.

@phm07 phm07 added the refactor label Jan 2, 2024
@phm07 phm07 self-assigned this Jan 2, 2024
@phm07 phm07 requested a review from a team as a code owner January 2, 2024 12:37
Copy link

codecov bot commented Jan 2, 2024

Codecov Report

Attention: 69 lines in your changes are missing coverage. Please review.

Comparison is base (af9dec4) 45.98% compared to head (22c9f23) 45.98%.

Files Patch % Lines
internal/cmd/server/create.go 0.00% 0 Missing and 3 partials ⚠️
internal/cmd/server/shutdown.go 0.00% 0 Missing and 2 partials ⚠️
internal/cmd/volume/create.go 0.00% 0 Missing and 2 partials ⚠️
internal/cmd/certificate/create.go 0.00% 0 Missing and 1 partial ⚠️
internal/cmd/firewall/add_rule.go 0.00% 0 Missing and 1 partial ⚠️
internal/cmd/firewall/apply_to_resource.go 0.00% 0 Missing and 1 partial ⚠️
internal/cmd/firewall/create.go 0.00% 0 Missing and 1 partial ⚠️
internal/cmd/firewall/delete_rule.go 0.00% 0 Missing and 1 partial ⚠️
internal/cmd/firewall/remove_from_resource.go 0.00% 0 Missing and 1 partial ⚠️
internal/cmd/firewall/replace_rules.go 0.00% 0 Missing and 1 partial ⚠️
... and 55 more
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #655   +/-   ##
=======================================
  Coverage   45.98%   45.98%           
=======================================
  Files         171      171           
  Lines        7514     7514           
=======================================
  Hits         3455     3455           
  Misses       3616     3616           
  Partials      443      443           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@phm07 phm07 merged commit f636b5e into main Jan 2, 2024
3 checks passed
@phm07 phm07 deleted the refactor-actionwaiter branch January 2, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants