Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DnsPolicy results in crashing istio proxy #559

Open
simonostendorf opened this issue Nov 12, 2023 · 4 comments · Fixed by #560
Open

DnsPolicy results in crashing istio proxy #559

simonostendorf opened this issue Nov 12, 2023 · 4 comments · Fixed by #560
Assignees
@apricote
Labels
bug Something isn't working pinned

Comments

@simonostendorf
Copy link
Contributor

I am using the hcloud cloud controller manager together with the istio sidecar proxy.

The istio proxy is stuck in a crash loop because it can't find the istiod host (Error while dialing: dial tcp: lookup istiod.istio-system.svc on 185.12.64.1:53: no such host). This is using the hetzner dns here (where obviously the entry can not be found).

If I switch the dnsPolicy inside the deployment to ClusterFirst everything works as expected.

Is there a reason why it is configured to use Default?

See here, here, here and here.
@apricote
Copy link
Member

Mh, I tried to figure out why its set this way, but it was introduced in the second commit of the repository without any comment: 785dd83#diff-b6264178c40e2a300a57855f7bbd1de74003cb68b4b9ac834432c73309f5c9bcR39

I think we can just remove it, in that case it would default to ClusterFirst. Do you want to submit a PR?

@apricote apricote added bug Something isn't working good first issue Good for newcomers labels Nov 13, 2023
@simonostendorf
Copy link
Contributor Author

Mh, I tried to figure out why its set this way, but it was introduced in the second commit of the repository without any comment: 785dd83#diff-b6264178c40e2a300a57855f7bbd1de74003cb68b4b9ac834432c73309f5c9bcR39

I think we can just remove it, in that case it would default to ClusterFirst. Do you want to submit a PR?

Thanks for your reply. Yes I can submit a PR.

@simonostendorf simonostendorf mentioned this issue Nov 13, 2023
Merged
apricote pushed a commit that referenced this issue Nov 14, 2023
@simonostendorf
fix(deployment): remove dns-policy (#560)
2c83786 
The `Default` DNS Policy is not really required and we are fine
with the default `ClusterFirst`. This fixes an issue when deploying
additional sidecars that need to access cluster internal services.

Closes #559
@hcloud-bot hcloud-bot mentioned this issue Nov 14, 2023
Merged
@apricote apricote reopened this Nov 21, 2023
@apricote
Copy link
Member

There was an issue afterall with removing the DNS policy. I will try to find a solution that works for all cases.

@apricote apricote self-assigned this Nov 21, 2023
@apricote apricote removed the good first issue Good for newcomers label Nov 21, 2023
@github-actions GitHub Actions
Copy link
Contributor

This issue has been marked as stale because it has not had recent activity. The bot will close the issue if no further action occurs.

@github-actions github-actions bot added the stale label Feb 19, 2024
@apricote apricote added pinned and removed stale labels Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@apricote apricote

Labels
bug Something isn't working pinned
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(deployment): remove dns-policy
2 participants
@apricote @simonostendorf