-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inconsistency in the naming for load balancer annotation. #656
Comments
|
I would be more concerned about people using http-redirect-https (as it is shown in the docs) in a misconfigured way causing it to break after an update. Perhaps just have a new annotation called ssl-redirect (same as ingress-nginx). |
After looking at it again, I understand why To help with some confusion, but keep it mostly consistent with the API we would prefer the following solution:
|
This issue has been marked as stale because it has not had recent activity. The bot will close the issue if no further action occurs. |
hcloud-cloud-controller-manager/internal/annotation/load_balancer.go
Line 161 in e2b0ed6
Isn't this supposed to be http-redirect-https? Most guides also say that it's http-redirect-https, but in the code itself it's http-redirect-http.
The text was updated successfully, but these errors were encountered: