Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Profile avatar uses nickname and it's overflowing the available space #530

Open
sergiozeppo opened this issue Jul 21, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@sergiozeppo
Copy link
Contributor

Summary

Hey there!
Just decided to register.
Chose the most relevant option for me - via github account.

Problem description

And after login procedure noticed the little bug, I think.
Take a look at profile avatar:
image
It seems like my nickname is significantly overflows over the available space.
And IMHO it shouldn't be there.

Proposed solution

I propose two ways of solving this problem.

  • The first option is to pull up the account icon when logging in via github (as some sites do, e.g. codewars).
    image

  • The second option is to leave 1-2 capitalized characters instead of the user's nickname (as mail services like mail.ru or gmail does).
    image

In my opinion, any of these options would be better than the existing solution.

Reproduction steps

1. Go to "https://runit.hexlet.ru/"
2. Click the "Войти" button
3. Choose the Github logging option
4. Take a look at the profiles avatar
5. Notice the bug.

Expected result

Described above

Actual result

Described above

Browsers

Chrome

OS

Windows

@sergiozeppo sergiozeppo added the bug Something isn't working label Jul 21, 2024
@Mehdi-Messaadi
Copy link
Contributor

Hi!
I'd like to take on this issue, please.
I'll soon create a pull request with my changes.

Mehdi-Messaadi added a commit to Mehdi-Messaadi/runit that referenced this issue Jul 24, 2024
…re, or capitalized 1st letter of username if the former is not applicable.
Mehdi-Messaadi added a commit to Mehdi-Messaadi/runit that referenced this issue Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: No status
Development

No branches or pull requests

2 participants