Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

closed tag problem of generated HTML #3652

Closed
JoeyBling opened this issue Aug 6, 2019 · 14 comments · Fixed by #3653
Closed

closed tag problem of generated HTML #3652

JoeyBling opened this issue Aug 6, 2019 · 14 comments · Fixed by #3653

Comments

@JoeyBling
Copy link

When I execute hexo s-g or hexo g
The generated HTML tag does not end properly,But it doesn't affect browser rendering
The version I used 3.9.0
But I didn't have this problem with version 3.7.1

I use the theme yilia-plus
I've tried this with the official default theme,But problems remain
How can i debug or fix it ?

@curbengh
Copy link
Contributor

curbengh commented Aug 6, 2019

I noticed this issue before, though I couldn't reproduce it reliably

Can you attach your package.json and _config.yml (let me know if they're private)? It may be caused by plugins.

@JoeyBling
Copy link
Author

@curbengh Thank you for your reply
I use the official default theme landscape,the problem can also occur!
The other configurations were left untouched.
version 3.9.0

@JoeyBling
Copy link
Author

@curbengh At the beginning I also thought the theme plug-in problem, later I directly use the 'hexo init' command to initialize a new project will also appear this problem

@curbengh
Copy link
Contributor

curbengh commented Aug 6, 2019

I can reproduce the issue, but not in local testing after modify something. Annoyingly, I can't remember the changes I made.

I'll do more testing.

@JoeyBling
Copy link
Author

JoeyBling commented Aug 6, 2019

@curbengh I've debugging, and find there's something wrong with this pull request

#3315

When I delete that file, the problem won't appear

  • lib/plugins/filter/meta_generator.js

But I don't know if there will be any other problems later, so I would like to ask for your help. Thank you

@curbengh
Copy link
Contributor

curbengh commented Aug 6, 2019

Somehow in my cause the issue goes away even with "meta_generator.js".
Can you try this modified landscape theme?

@JoeyBling
Copy link
Author

@curbengh I don't think it's about the subject. I'll try first

@JoeyBling
Copy link
Author

@curbengh Sorry, I take back what I said just now, this modified theme is actually ok,
But the question is what?
I don't know

@JoeyBling
Copy link
Author

I use the theme yilia-plus

@yoshinorin
Copy link
Member

yoshinorin commented Aug 6, 2019

@JoeyBling @curbengh
My understanding is that this issue has already been solved hexojs/hexo-theme-landscape#123

@JoeyBling
Copy link
Author

@yoshinorin Thank you very much. You solved my problem perfectly. I fixed my theme according to this bug

And I have another question, how to remove the meta tag generator property generated

<meta name="generator" content="Hexo 3.9.0">

@JoeyBling
Copy link
Author

fix it

hexojs/hexo-theme-landscape#123

@curbengh
Copy link
Contributor

curbengh commented Aug 6, 2019

And I have another question, how to remove the meta tag generator property generated

currently, there is no option to disable it. I could add the option.

@JoeyBling
Copy link
Author

@curbengh I think your can add this and look forward to fix it in the next release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants