Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax Highlighting: add support for Shiki #5545

Open
2 tasks done
noraj opened this issue Sep 14, 2024 · 2 comments
Open
2 tasks done

Syntax Highlighting: add support for Shiki #5545

noraj opened this issue Sep 14, 2024 · 2 comments

Comments

@noraj
Copy link
Contributor

noraj commented Sep 14, 2024

Check List

  • I have already read Docs page.
  • I have already searched existing issues.

Feature Request

In addition to highlight.js and pism.js, it would be nice to have support for Shiki for syntax highlighting.

highlight.js and pism.js are lightweight, but have very basic syntax parsing while Shiki has a power powerful and complete lexer / tokenizer.

Others

References:

Plugins:

@uiolee
Copy link
Member

uiolee commented Oct 7, 2024

Sounds great.
but why we need "add support" when it can be done through a plugin?

@noraj
Copy link
Contributor Author

noraj commented Oct 7, 2024

I don't know, generally, how do you choose if something should be part of hexo core or let managed by a third party plugin?

The plugins are not clean, one is only supporting 4 themes, one is not working, one is injecting CSS in a dirty way, etc.

Having it core would support more option and be integrated in a cleaner way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants