Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of make conj #38

Open
hferee opened this issue Oct 15, 2024 · 1 comment
Open

Get rid of make conj #38

hferee opened this issue Oct 15, 2024 · 1 comment

Comments

@hferee
Copy link
Owner

hferee commented Oct 15, 2024

Try to replace make_conj with And (and similarly for disjunction and implication) to see if it makes the benchmarks worse

@hferee
Copy link
Owner Author

hferee commented Oct 19, 2024

Reporting progress: while investigating #33, I changed the implementation of choose_conj with its naive implementation ; thus impacting make_conj and conjunction.

This makes for identical results (and better speed) in all benchmark cases, except for (x <-> (p ∨ ¬p)) ∧ (y <-> (q ∨ ¬q)) ∧ ¬(p ∧ q) which times out.
The issue is in conjunction ; seemingly highly inefficient in that case.
Counterintuitively, it seems to make more calls to Provable_dec.

We'll see if the solution above fixes this issue too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant