Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make hack files the default #156

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Make hack files the default #156

wants to merge 3 commits into from

Conversation

lexidor
Copy link
Contributor

@lexidor lexidor commented May 25, 2023

fixes #112

Fixes:

  • Files without a legacy extension .php, .hh, are treated as DOT_HACK.
  • Same goes for .hhi
  • Bumps minimum hhvm version to 4.153.

lexidor added 3 commits May 25, 2023 08:40
@lexidor
Require hhvm 4.153
01627bc 
This is the first LTS with the, if not legacy then mode = .hack, change.
For users on older UNSUPPORTED versions of hhvm, we can't remove the sigils.
@lexidor
Treat files without a legacy extension as DOT_HACK
d1a20b1
@lexidor
Formatting the affected files
654cf62
@lexidor lexidor mentioned this pull request May 28, 2023
Open
@lexidor
Copy link
Contributor Author

lexidor commented May 28, 2023

Fixes hhvm/hack-router-codegen#18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make .hack files the default in a future release
2 participants
@lexidor @facebook-github-bot