You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
For our current use of addMultilineCall, it's fairly common to pass literals as arguments, including nested arrays. Would be nice if we could use HackBuilderValues::export() rather than having to do it manually.
The text was updated successfully, but these errors were encountered:
Waking this issue from its multi year slumber. My instinct says: Why not both?
Keep the current addMultilineCall() around, since requiring a builder for a true literal would be cumbersome. Add a new method which takes on builder and apply it to all arguments.
I am not sure a third version taking builder+value pairs would be much more convenient than using the builders at the call site. There is no need to add this in the same PR, so that may/might be postponed (indefinitely?).
For our current use of
addMultilineCall
, it's fairly common to pass literals as arguments, including nested arrays. Would be nice if we could useHackBuilderValues::export()
rather than having to do it manually.The text was updated successfully, but these errors were encountered: