Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove quick-error dependency? #20

Open
jplatte opened this issue Jul 1, 2020 · 1 comment · May be fixed by #35
Open

Remove quick-error dependency? #20

jplatte opened this issue Jul 1, 2020 · 1 comment · May be fixed by #35

Comments

@jplatte
Copy link

jplatte commented Jul 1, 2020

Since you removed it from humantime, maybe you're planning to remove / replace it here too? I hardly see it used anymore, and would be happy to have a slightly leaner dependency graph :)

EDIT: I had a look at quick-error again, it seems less heavy than e.g. failure or snafu. So I guess it's fine, though it could still be an improvement for readability to remove the dependency. Feel free to close this issue without further comment if you want to keep the dependency.

@tailhook
Copy link
Collaborator

tailhook commented Jul 1, 2020

Removing it in favor of manual code like in humantime can be done if contributed. The hardest part of that is keeping backwards compatibility with old error. I don't see any reason of replacing it with some codegen library at this moment as this is a pretty small and low-maintenance crate (i.e. new errors would not happen too often).

@alex-hunt-materialize alex-hunt-materialize linked a pull request Mar 14, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants