Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update UI component for Knock In App Notifications Display #9762

Closed
dillchen opened this issue Nov 1, 2024 · 12 comments · Fixed by #10175 or #11386
Closed

Update UI component for Knock In App Notifications Display #9762

dillchen opened this issue Nov 1, 2024 · 12 comments · Fixed by #10175 or #11386
Assignees

Comments

@dillchen
Copy link
Contributor

dillchen commented Nov 1, 2024

Description

We currently use the default Knock Provider In App. We should create a custom component to update the notifications In App Display.

Project Owner
@dillchen

User Stories / Acceptance Criteria

  • Notifications Display, Link Handling, Clear All etc all work as is

Design Devlink
https://www.figma.com/design/WdlVQRpQKg4GMgCOzbQt34/Notifications?node-id=604-224&t=alPU6pUtBFdRfroe-1

Design Screenshot

Old

image image

New

image

To Add Link Here

Additional Context

You will have to build this ontop of the Knock SDK, please follow their documentation link

@KaleemNeslit
Copy link
Collaborator

@Israellund is design confirm for this ticket ?

@Israellund
Copy link
Collaborator

@KaleemNeslit Not yet, a Figma link would be attached if so. I'll follow up with Design and see if they have anything for this.

@KaleemNeslit
Copy link
Collaborator

@KaleemNeslit Not yet, a Figma link would be attached if so. I'll follow up with Design and see if they have anything for this.

i sent request for access

@Israellund
Copy link
Collaborator

@KaleemNeslit my bad, didn't see that link. Let me get you access.

@KaleemNeslit
Copy link
Collaborator

@Israellund how do i enable notification , how do i get knockJWT and other related thing to start this ticket

@Israellund
Copy link
Collaborator

@KaleemNeslit I'm looking into any Knock env vars, are you currently unable to start working on this?

@KaleemNeslit
Copy link
Collaborator

@KaleemNeslit I'm looking into any Knock env vars, are you currently unable to start working on this?

yes i am not able start work on this as i am not able to receive notification @Israellund

@Israellund
Copy link
Collaborator

@KaleemNeslit just sent you a message on slack with env vars, let me know if those work.

@KaleemNeslit
Copy link
Collaborator

@Israellund still not able to receive notification and not able to see notification icon

@Israellund
Copy link
Collaborator

@Israellund still not able to receive notification and not able to see notification icon

Just sent you Knock env vars. Let me know if you still can't receive anything

@dillchen
Copy link
Contributor Author

@KaleemNeslit, sorry I have to reopen the ticket, I linked to the wrong frame, please see updated screenshot

@dillchen
Copy link
Contributor Author

dillchen commented Mar 5, 2025

Kaleem, I'm rebumping this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants