Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the usages of KVState.keys() methods #17846

Open
Neeharika-Sompalli opened this issue Feb 12, 2025 · 0 comments
Open

Replace the usages of KVState.keys() methods #17846

Neeharika-Sompalli opened this issue Feb 12, 2025 · 0 comments
Assignees
Milestone

Comments

@Neeharika-Sompalli
Copy link
Contributor

Neeharika-Sompalli commented Feb 12, 2025

Once MegaMap is implemented , in addition to stopping the use of KVState.size() method, using KVState.keys() is not going to be performance efficient.

    public Iterator<K> keys() {
        return iterateFromDataSource();
    }

For example, This is used to iterate through StakingInfo map. Replace the usage of keys method and instead get all nodes from roster entries.

@Neeharika-Sompalli Neeharika-Sompalli self-assigned this Feb 12, 2025
@Neeharika-Sompalli Neeharika-Sompalli added this to the v0.60 milestone Feb 12, 2025
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Services Team Feb 12, 2025
@Neeharika-Sompalli Neeharika-Sompalli moved this from 📋 Backlog to To Do in Services Team Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant