Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[amm] Normalize the "timeToMaturity" argument in "YieldSpace.sol" #53

Open
PaulRBerg opened this issue Oct 5, 2021 · 0 comments
Open

[amm] Normalize the "timeToMaturity" argument in "YieldSpace.sol" #53

PaulRBerg opened this issue Oct 5, 2021 · 0 comments
Labels
enhancement Improvement for an existing feature or system package:amm

Comments

@PaulRBerg
Copy link
Contributor

PaulRBerg commented Oct 5, 2021 •
edited
Loading

All arguments come normalized in the functions defined in YieldSpace.sol, except for the timeToMaturity argument, which is normalized internally in the library. The style would be more consistent if we asked users to normalize all function arguments before they call any function.
@PaulRBerg PaulRBerg added enhancement Improvement for an existing feature or system package:amm labels Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Improvement for an existing feature or system package:amm
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@PaulRBerg