Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define "waitForConfirmations" Hardhat task only once #84

Open
PaulRBerg opened this issue Mar 21, 2022 · 0 comments
Open

Define "waitForConfirmations" Hardhat task only once #84

PaulRBerg opened this issue Mar 21, 2022 · 0 comments
Labels
enhancement Improvement for an existing feature or system

Comments

@PaulRBerg
Copy link
Contributor

In 087d03b, we eliminated the tasks package, and moved the tasks in one of the smart contracts package (the one associated with each contract deployed).

One of the side-effects of that refactor was the massive duplication of the waitForConfirmations Hardhat task. It can be found in all smart contracts packages now.

We should find a way to avoid repeating ourselves and define this Hardhat task only once.
@PaulRBerg PaulRBerg added the enhancement Improvement for an existing feature or system label Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Improvement for an existing feature or system
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@PaulRBerg