Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library production build error on latest version 3.1.0 #345

Open
joeveiga opened this issue Feb 2, 2023 · 6 comments
Open

Library production build error on latest version 3.1.0 #345

joeveiga opened this issue Feb 2, 2023 · 6 comments
Assignees

Comments

@joeveiga
Copy link

joeveiga commented Feb 2, 2023

Describe the bug

It works fine up to v3.0.0. Latest update caused an error on our build pipeline with what it seems to be breaking changes introduced on v3.1.0.

An unhandled exception occurred: node_modules/highcharts-angular/lib/highcharts-chart.component.d.ts:24:18 - 
error TS2314: Generic type 'ɵɵComponentDeclaration' requires 7 type argument(s).

24     static ɵcmp: i0.ɵɵComponentDeclaration<
  HighchartsChartComponent,
  "highcharts-chart",
  never, { 
    "Highcharts": "Highcharts";
    "constructorType": "constructorType";
    "callbackFunction": "callbackFunction";
    "oneToOne": "oneToOne";
    "runOutsideAngular": "runOutsideAngular";
    "options": "options";
    "update": "update"; 
  }, { 
    "updateChange": "updateChange";
    "chartInstance": "chartInstance"; 
  }, 
  never, 
  never, 
  false, 
  never
>;

Expected behavior

Minor version changes to be compatible.

Setup used

  • NodeJS version: 14

  • Angular version: 13.3.4

  • TypeScript version: 4.6.4

{
  "compileOnSave": false,
  "compilerOptions": {
    "baseUrl": "./",
    "outDir": "./dist/out-tsc",
    "sourceMap": true,
    "declaration": false,
    "moduleResolution": "node",
    "emitDecoratorMetadata": true,
    "experimentalDecorators": true,
    "esModuleInterop": true,
    "resolveJsonModule": true,
    "allowSyntheticDefaultImports": true,
    "module": "es2020",
    "target": "es2017",
    "typeRoots": ["node_modules/@types"],
    "lib": ["es2017", "dom", "es2019", "ESNext.BigInt"],
    }
  },
  "angularCompilerOptions": {
    "strictTemplates": false,
    "compilationMode": "partial"
  }
}

@jthorsen
Copy link

jthorsen commented Feb 3, 2023

Angular dependency was changed from 13 to 14. I had to use ~3.0.0 instead of ^3.0.0 to avoid 3.1.x

@karolkolodziej
Copy link
Contributor

@jthorsen that is correct my mistake!
For Angular version 13 please use highcharts-angular in version 3.0.0

@izbushka
Copy link

izbushka commented Feb 3, 2023

The build also fails on angular 14.2.12

@karolkolodziej
Copy link
Contributor

You are right, I see a similar issue with Angular 14... in 15 it looks alright.

I will wait for the Highcharts v11 release (which should be in a couple of weeks) and after that, I will release a new major version of this wrapper.

I apologize for the inconvenience- right now it looks like using version 3.0.0 is a valid solution for older Angular versions.

@minijus
Copy link

minijus commented May 11, 2023

@karolkolodziej are there still plans to release new major version of highcharts-angular that works with Angular 14+ (including v16)?

@karolkolodziej
Copy link
Contributor

Hi @minijus! As far as I see, you can correctly use the highcharts-angular with the Angular 16- demo.

But nevertheless, in the nearest future, we will release a new version 😄

@ddragula ddragula self-assigned this May 16, 2023
alanorth added a commit to ilri/OpenRXV that referenced this issue Jul 28, 2023
Pin highcharts-angular at 3.0.x to fix TypeScript errors with
Angular v14.

See: highcharts/highcharts-angular#345
alanorth added a commit to ilri/OpenRXV that referenced this issue Jul 28, 2023
Pin highcharts-angular at 3.0.x to fix TypeScript errors with
Angular v14.

See: highcharts/highcharts-angular#345
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants